You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I do not like the word "Exception" here, because Rust doesn't have the term exception in its library, in contrast to other languages, e.g. C#, Java, C++, ...
The Rust documentation ueses the word "Panics" when it will panic under certain conditions (e.g. u32::overflowing_div).
I would suggest to adopt the phrasing.
The text was updated successfully, but these errors were encountered:
You're right that "Exception" probably isn't the correct phrasing. However, those items listed under "Exceptions" are conditions that, when met, will cause the function to return an Err and not directly cause a panic. Perhaps rephrasing to "Errors" would be the most appropriate?
https://github.com/brycx/orion/blob/f5db759f157921c31c571868757900eedd2bcdcf/src/aead.rs#L48-L57
I do not like the word "Exception" here, because Rust doesn't have the term exception in its library, in contrast to other languages, e.g. C#, Java, C++, ...
The Rust documentation ueses the word "Panics" when it will panic under certain conditions (e.g.
u32::overflowing_div
).I would suggest to adopt the phrasing.
The text was updated successfully, but these errors were encountered: