Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random secret-key/nonce generation to stream cipher and AEAD tests #123

Merged
merged 4 commits into from
Jun 7, 2020

Conversation

brycx
Copy link
Member

@brycx brycx commented Jun 7, 2020

Fixes #119. See message of fb98f20 for more details on why this was implemented this way.

brycx added 3 commits June 7, 2020 12:07
…/Aead)TestRunner

This must be implemented seperately from the test runner, and is therefor a pub function.
The reason for this is, that the trait that let's us randomly generate these types, should
only be available when testing. But since StreamCipherTestRunner is used in intergation tests (/tests),
compiling it conditionally with cfg(test) would still make it inaccessible in /tests. Using
cfg(debug_assertions) is not desired either, because we want to test in both release and debug mode.
@brycx brycx added the testing All testing, except for fuzzing related label Jun 7, 2020
…ome very small lengths, 'collisions' would occur.
@brycx brycx merged commit fda1c14 into master Jun 7, 2020
@brycx brycx deleted the issue-119 branch June 7, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing All testing, except for fuzzing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to randomly generate SecretKey and Nonce in (StreamCipher/Aead)TestRunner
1 participant