Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subtle From<Choice> for bool impl instead of using unwrap_u8 #66

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

brycx
Copy link
Member

@brycx brycx commented Mar 23, 2019

This should avoid potential short-circuits. Using unwrap_u8 was completely useless here.

@brycx brycx added security Security-related issues or improvements improvement General improvements to code labels Mar 23, 2019
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #66 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   96.39%   96.37%   -0.02%     
==========================================
  Files          47       47              
  Lines        6656     6655       -1     
==========================================
- Hits         6416     6414       -2     
- Misses        240      241       +1
Impacted Files Coverage Δ
src/util/mod.rs 100% <100%> (ø) ⬆️
src/typedefs.rs 97.87% <100%> (-0.01%) ⬇️
src/hazardous/xof/cshake.rs 97.69% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64181e1...d12bc90. Read the comment docs.

@brycx brycx merged commit 0c5c50f into master Mar 31, 2019
@brycx brycx deleted the short-circuits branch March 31, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement General improvements to code security Security-related issues or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant