Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why TryFrom<String> not TryFrom<&str>? #53

Closed
Eh2406 opened this issue May 24, 2022 · 2 comments
Closed

Why TryFrom<String> not TryFrom<&str>? #53

Eh2406 opened this issue May 24, 2022 · 2 comments

Comments

@Eh2406
Copy link

Eh2406 commented May 24, 2022

Why TryFrom<String> not TryFrom<&str>?
For example here https://docs.rs/pasetors/0.5.0-alpha.5/src/pasetors/paserk.rs.html#129-141
Why do we need to own the string in order to convert it into a pasetors type?
@brycx
Copy link
Owner

brycx commented May 25, 2022

There should be no reason and this should definitely be TryFrom<&str>. I don't know why this wasn't so to begin with.

@brycx brycx mentioned this issue May 26, 2022
Merged
@brycx
Copy link
Owner

brycx commented May 26, 2022

Included in the latest prerelease: https://crates.io/crates/pasetors/0.5.0-alpha.6

@brycx brycx closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eh2406 @brycx