Complete Rewrite for Rails 3/4 & Ajax #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persistent toolbar position
Add pry
Implement EnableButton and Toolbar with Rack::Toolbar; Extract PathMatchFilters to mixin; Add specs for EnableButton and Toolbar; Remove specs that are pushed to Rack::Toolbar
d3cfc5a introduced a `warn` statement that prints when redis is not available. This gets printed whenever the rails environment gets loaded (so, `rails s`, `rails c, `rake`, etc) which is a bit annoying. The output also broke some specs in a project that was checking the stdout of some of our scripts. @pboling suggested there's a better implementation in http://git.io/vfGPX
Remove log output when redis isn't loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: @brynary and I have discussed and agree that we'd like to merge the projects rack-bug and rack-insight together.
I forked LogicalInsight (which was a substantial rewrite itself) and rewrote it to be much better. We are moving towards a kick-ass merger/migration between the venerable Rack::Bug and the new Rack::Insight. Spec suite has also been updated!
My next major goal is to spit each panel out into it's own gem so the panel's dependencies can be managed separately, since they are very version specific, and there is no need for
/rack-(bug|insight)/to be tied down to dependencies of dependencies. Rather panels should support a specific, versioned,/rack-(bug|insight)/panel API.