Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Complete Rewrite for Rails 3/4 & Ajax #53

Open
wants to merge 339 commits into from
@pboling

NOTE: @brynary and I have discussed and agree that we'd like to merge the projects rack-bug and rack-insight together.

I forked LogicalInsight (which was a substantial rewrite itself) and rewrote it to be much better. We are moving towards a kick-ass merger/migration between the venerable Rack::Bug and the new Rack::Insight. Spec suite has also been updated!

My next major goal is to spit each panel out into it's own gem so the panel's dependencies can be managed separately, since they are very version specific, and there is no need for /rack-(bug|insight)/ to be tied down to dependencies of dependencies. Rather panels should support a specific, versioned, /rack-(bug|insight)/ panel API.

pboling and others added some commits
@pboling pboling Fixed view rendering 55dfade
@pboling pboling Bump to 0.5.3 0ee89a1
@pboling pboling Bump to 0.5.4 3e302a5
@pboling pboling tweaks 4782a1d
@pboling pboling New Logging e5175ff
@pboling pboling Fixed probe when constant not found fd55c9c
@pboling pboling Update to new logging fafd787
@pboling pboling Reducing Verbosity 616809e
@pboling pboling Logging improvements 4e3c9b5
@pboling pboling Implement a template_root solution for extension gems to hook into 0b363bf
@pboling pboling Bump to 0.5.5 020d33c
@pboling pboling Document changes d532c5a
@pboling pboling Wrap debug logging in verbose check 2218665
@pboling pboling Bump to 0.5.6 d53f154
@pboling pboling Documenting new configuration options 0378065
@pboling pboling require Ruby logger 124ab7b
@pboling pboling Easier for Rubymine to parse 18c88a6
@pboling pboling For 0.5.6 dac2a9b
@pboling pboling Bump to 0.5.7 3b29922
@pboling pboling For 0.5.7 a8c9622
@pboling pboling working template_root for rack-insight extension libraries b200585
@pboling pboling for 0.5.8 16cc4eb
@pboling pboling Bump to 0.5.8 acb0563
@pboling pboling Turned FilteredBacktrace back on, and made configurable b33dd19
@pboling pboling Document 0.5.9 1a89fc7
@pboling pboling Bump to 0.5.9 8645155
@pboling pboling For 0.5.9 4050a34
@pboling pboling Fixes release dates d8e9219
@pboling pboling Make ajax requests to root 52d3539
@pboling pboling For 0.5.10 2645a5c
@pboling pboling Bump to 0.5.10 6b0856c
@pboling pboling Fix encoding issue (copied from Rack::Bug) e1b7b3b
@pboling pboling Bump to 0.5.11 4bf086d
@pboling pboling for 0.5.11 809f502
@subosito subosito persistent toolbar position 0294ee1
@pboling pboling Merge pull request #2 from subosito/persistent_toolbar_position
Persistent toolbar position
cc03f43
@pboling pboling Improving documentation f47924f
@pboling pboling for v0.5.12 fbe3205
@pboling pboling So Rubymine can parse it c349367
@pboling pboling Updating Gemfile.lock d3cf5da
@pboling pboling Bump to 0.5.12 bdef58c
@pboling pboling for v0.5.12 c0ba090
@pboling pboling Removed :req_num logging from cache_panel 0af6dd1
@pboling pboling whitespace cleanup 31ad226
@pboling pboling Allow panel specific conigurations 6fee11e
@pboling pboling Handle log_panel config for which loggers to watch fa26b8e
@pboling pboling More Examples 3d50ae8
@pboling pboling Bump to 0.5.13 118dfad
@pboling pboling WIP: Panel.tableless, panel_configs, auto-tables and config-based pro…
…bing
649cb29
@pboling pboling Magic Panels 41a235f
@pboling pboling Bump to 0.5.14 840fa82
@pboling pboling for v0.5.14 d7fc3dd
@pboling pboling Fix README b675a52
@pboling pboling Magic Panels improved 4b622e0
@pboling pboling Bump to 0.5.15 279bbbf
@pboling pboling Handle no content well 09773a3
@pboling pboling Bump to 0.5.16 fbd221b
@pboling pboling Improve toolbar experience when docked at bottom and top. Do not obsc…
…ure page content.
f38681c
@pboling pboling == 0.5.17 / 2012-09-13 - Peter Boling
  * New Features
    * MagicInsight!  WARNING: Magic is dangerous.
      * MagicInsight is a new mixin that can be used by any 'stat' type class built for Rack::Bug / LogicalInsight / Rack::Insight.
        Just include Rack::Insight::MagicInsight in your stat class and then to render call:
            render_template 'magic_panel', :magic_insights => your_stat_object, :name => 'panel name'
        Read the source for Rack::Insight::MagicInsight and heed the warnings.
        MagicInsight is used internally by Rack::Insight for magic panels and the templates panel.
  * Bug Fixes
    * Fixed the hardly working TemplatesPanel (Issue 1)
    * Correct logging/debug statements
    * Better tracking of which panels are probing
  * Other
    * TemplatesPanel is now more aligned with the Rack::Insight Panel API.
5e9e424
@pboling pboling Bump to 0.5.17 a273376
@pboling pboling Fix typo in templates panel c62bf18
@pboling pboling panel content is no longer covered by panel toolbar when positioned o…
…n bottom
1b36c9a
@pboling pboling for v0.5.18 f28c834
@pboling pboling Bump to 0.5.18 51e32af
@oggy oggy Fix Redis extension for Redis 3.x. a7bb990
@pboling pboling Merge pull request #4 from oggy/rack-insight
Fix Redis extension for Redis 3.x.
bd8720d
@oggy oggy Call original Redis::Client#call in redis extension. b7cf279
@pboling pboling Merge pull request #5 from oggy/rack-insight
Call original Redis::Client#call in redis extension.
1e3ced0
@pboling pboling Document changes b1aec01
@pboling pboling Improved table template for magical panels e194680
@pboling pboling Merge branch 'master' of github.com:pboling/rack-insight 8d50aa6
@pboling pboling more change documentation 4438c9e
@pboling pboling Update .travis.yml e46d40c
@pboling pboling Expand backtrace for header render errors 8f53810
@pboling pboling Bump to 0.5.19 1cc5670
@pboling pboling Fix panel error handling c5b0b8c
@pboling pboling Bump to 0.5.20 5194eed
@pboling pboling Attempting to handle values that get stored in the sqlite db, but whi…
…ch can't be re-marshalled, without failing the entire panel
155ac36
@pboling pboling == 0.5.21 / 2012-09-13 - Peter Boling
* Attempting to handle values that get stored in the sqlite db, but which can't be re-marshalled, without failing the entire panel
* Much nicer error handling output in panel heading and panel content areas
801860d
@pboling pboling Bump to 0.5.21 0b73e1d
@oggy oggy Fixes for redis panel.
Pass block to original #call, and don't wrap reported calls in a
redundant array for Redis 3.x clients.
de10629
@pboling pboling Merge pull request #7 from oggy/redis
Redis panel patch
e91bd3c
@pboling pboling Improved handling of decoding and marshalling problems 3f3128d
@pboling pboling for v0.5.22 7371321
@pboling pboling Merge branch 'master' of github.com:pboling/rack-insight 9607c7d
@pboling pboling for v0.5.22 8ac02db
@pboling pboling Bump to 0.5.22 1eccd9a
@pboling pboling Stop rescuing Object 0561ffb
@pboling pboling Panel#handle_error_for 3d00343
@pboling pboling Bump to 0.5.23 c15e6d0
@oggy oggy Make redis panel support AJAX requests. 00597ea
@oggy oggy Revive sphinx panel. Supports AJAX. 804f54d
@oggy oggy Add missing query attributes and backtrace to sphinx panel. be89aa4
@oggy oggy Use debugger gem, for 1.9.3 support. cf15c5a
@pboling pboling Merge pull request #9 from oggy/redis
AJAX support for redis panel
5f009c9
@pboling pboling Merge pull request #10 from oggy/sphinx
Sphinx panel, with AJAX support
07765b3
@pboling pboling Merge pull request #11 from oggy/debugger
Use debugger gem, for 1.9.3 support.
ae4d3f1
@pboling pboling The Sphinx is back e2e538f
@pboling pboling The Sphinx is back
spelling fix
3a1e687
@pboling pboling Update README.md 1dbdcc1
@pboling pboling Update README.md 8d70d16
@pboling pboling Update README.md 315c58f
@pboling pboling Gemnasium 90c7d78
@natejgreene natejgreene small fix for javascript d432025
@natejgreene natejgreene small fix for javascript 6fb61b4
@pboling pboling Merge pull request #16 from natejgreene/jquery_conflict_fix
small fix for javascript
d2164ff
@pboling pboling Coderwall link 4a9a3fd
@pboling pboling Fixes Issue #17 0d77f7f
@pboling pboling Update Changelog for 0.5.24 release f4fd0bf
@pboling pboling Merge branch 'master' of https://github.com/pboling/rack-insight 175dbb6
@pboling pboling Bump to 0.5.24 b10c746
@pboling pboling fixed typo 98d967d
@pboling pboling Update README.md fbb4b49
@pboling pboling update Gemfile.lock d18e374
@pusewicz pusewicz Use on instead of live 6f5b9a8
@pboling pboling Merge pull request #18 from pusewicz/jquery-1.9
Use on instead of live for jQuery 1.9 compatibility
7c78a34
@kjg kjg Make ActiveRecord work again
By probing ActiveRecord::Base not ActiveRecord
db33291
@pboling pboling Merge pull request #19 from kjg/patch-1
Make ActiveRecord work again
d60f395
@pboling pboling New version of debugger efb1550
@pboling pboling Added contributors; Mention active_record_panel fix 2476b46
@pboling pboling Merge branch 'master' of https://github.com/pboling/rack-insight d2f7fb8
@pboling pboling document 0.5.25 release 45d18a9
@pboling pboling Add gem-release 41f9128
@pboling pboling Bump to 0.5.25 82a2b1f
@pboling pboling code climate badge 2b06c21
@pboling pboling active_record_panel works now! fdc9c46
@pboling pboling code climate badge aea4cac
@haswalt haswalt Fix broken css for bottom toolbar 6db526e
@haswalt haswalt Set position to fixed to keep toolbar at bottom fa1d28b
@haswalt haswalt Allow panels to scroll when fixed to bottom 5bed643
@haswalt haswalt Dont reload page, just close panel 4869f4c
@agis- agis- Update README.md 4eca421
@pboling pboling Merge pull request #21 from Agis-/patch-1
Update README.md
d61dd92
@pboling pboling Still Maintained 826389e
@pboling pboling Merge pull request #20 from haswalt/master
Fix layout when fixed to bottom
235a26c
@pboling pboling Document 0.5.26 release c1a65cb
@pboling pboling Bump to 0.5.26 25b7e16
@pboling pboling Updating development dependencies b10e531
@pboling pboling Add license and platform to gemspec 1142c22
@pboling pboling Convert to .ruby-version 4fb8eee
@pboling pboling Require the standard Ruby Logger f6bd153
@pboling pboling Instrumentation specs fixed. f5f5751
@pboling pboling More fixes c4cd23e
@pboling pboling Fixed templates_panel_spec 6b6ccfb
@pboling pboling Fixed timer_panel_spec 4ed3bd1
@pboling pboling Fixed SQL Panel specs 447c45a
@pboling pboling Cannot run redis specs with redis client installed. e7ed0d3
@pboling pboling More spec cleanup e0c4f04
@pboling pboling Fixing deprecations 3a010d1
@pboling pboling Fixed rails info panel spec f16b603
@pboling pboling Fixed LogPanel spec cfea1a3
@pboling pboling All specs passing! a2dcf6b
@pboling pboling Removing unused development dependencies 2a2c16f
@pboling pboling ADding back reek and roodi 44981de
@pboling pboling No jruby (dies on sqlite3) 006074b
@pboling pboling spec.email should reflect who the current contacts are for the gem 22fbd9e
@pboling pboling Improved CHANGELOG fae9122
@pboling pboling Add Ruby 2.0.0 to travis; remove rbx-19mode c4f101a
@pboling pboling Improved configuration of logging and verbosity 665b11e
@pboling pboling Update CHANGELOG for v0.5.27 df6d110
@pboling pboling Bump to 0.5.27 79935fc
@pboling pboling Improved Readme fa4416f
@pboling pboling Attributions c7eeb2c
@pboling pboling Fix typo in example code b6aebd4
@pboling pboling Remove dependency on git for gemspec bc2727d
@pboling pboling add :handle_javascript option (default true) 3873579
@pboling pboling Respond to requests with text/plain mime type;
Utilize Rack::Request#media_type;
Pass through :handle_javascript option
34f011e
@pboling pboling Respond to requests with text/plain mime type;
Utilize Rack::Request#media_type;
Pass through :handle_javascript option
02fe9a4
@pboling pboling Quicker access to config 2b8a0bc
@pboling pboling Make use of handle_javascript 9401587
@bitdeli-chef bitdeli-chef Add a Bitdeli badge to README 49eec8e
@pboling pboling Merge pull request #26 from bitdeli-chef/master
Add a Bitdeli Badge to README
1126fb9
@pboling pboling Update README.md 48ba658
@pboling pboling Fix Gemspec 3a0d123
@pboling pboling Update rack-insight.gemspec 5dc5374
@pboling pboling revert reliance on rack's request.media_type fefbeaa
@pboling pboling pass :handle_javascript as a local to the toolbar template 8f042d3
@pboling pboling Update CHANGELOG for 0.5.28 release f4e5454
@pboling pboling Bump to 0.5.28 f977085
@pboling pboling Update README.md 2fe5750
@hck hck Fix bug with asset pipeline.
Check path filters before appendind button content to request body.
fc67143
@pboling pboling Merge pull request #28 from hck/master
Fix bug with asset pipeline.
027179b
@rrrene rrrene Add docs badge to README 1307256
@pboling pboling Merge pull request #29 from rrrene/patch-1
Add docs badge to README
42886f8
@bibendi bibendi remove js and button 1f9284e
@Napolskih Napolskih some fixes 2d285c6
@bibendi bibendi Merge pull request #1 from Napolskih/master
some fixes
882e505
@Napolskih Napolskih disable redis debug info verbose 2c3ccaf
@bibendi bibendi Merge pull request #2 from Napolskih/master
Disabled debug output Redis
5523519
@rrrene rrrene Update docs badge in README
Update the URL of the docs badge to include it from inch-ci.org instead of inch-pages.github.io (the former being the successor of the Inch Pages project).

[ci skip]
8b0e988
@pboling pboling Merge pull request #33 from rrrene/patch-2
Update docs badge in README
6dfd424
@bibendi bibendi fix inject body if body empty
Closes PC4-13514'
b40b3cb
@bibendi bibendi Merge branch 'master' of github.com:abak-press/rack-insight 40a34d5
@michaelmior michaelmior Remove bundler arguments c1f507b
@michaelmior michaelmior Update version in Gemfile.lock 5a8e75f
@pboling pboling Merge pull request #34 from michaelmior/travis-fix
Travis fix
4bcbd9d
@pboling pboling Delete Gemfile.lock e305268
@pboling pboling Ignore Gemfile.lock f81d11a
@pboling pboling No longer failing build! f2fa5d6
@pboling pboling ignore log generated by spec suite a7c76e1
@pboling pboling fix spec suite abef712
@pboling pboling Develop on modern Ruby! e07a341
@pboling pboling having trouble installing any other version of Nokogiri but 1.6.3.1 0ede546
@pboling pboling dry up readme c881c13
@pboling pboling Merge branch 'master' of https://github.com/abak-press/rack-insight i…
…nto abak-press-master

Conflicts:
	.gitignore
074f016
@pboling pboling fixed optional dependency loading d3cfc5a
@pboling pboling Merge branch 'abak-press-master' 97b65a9
@pboling pboling Fixed for Rails 4 4d78079
@pboling pboling Merge branch 'semenyukdmitriy-master' 51d59ac
@pboling pboling Fixing the serving of the toolbar c48cfcd
@pboling pboling less verbose a7bb3eb
@pboling pboling test the filter first 2a2fd13
@pboling pboling Revert the attempt at AMDifying the JS eafffc3
@pboling pboling less verbose c1a8e1c
@pboling pboling Bump to 0.5.29 698929f
@pboling pboling Working Example! 461e491
@pboling pboling changed the title from Complete Rewrite for Rails 3 & Ajax to Complete Rewrite for Rails 3/4 & Ajax
@javierhonduco

@javierhonduco - released 0.5.30 with the fix.

Hi, you mentioned in other commit, that this does not test a response, but body. As it seems to me, variable is named body, but response is assigned to it. For rails you would need to call body.body, to get actual string body, otherwise you have an rails response body and it does not implement an empty? method.

pboling and others added some commits
@pboling pboling Update .travis.yml 8e0bf73
@pboling pboling CHANGELOG for 0.5.30 fdbf09a
@pboling pboling Bump to 0.5.30 f45ad83
@puckbag puckbag fix enable button for spree a270a1e
@pboling pboling Merge pull request #39 from puckbag/puckbag/fix/enable-button
fix enable button for spree
c64c034
@pboling pboling upgrade to latest version of Ruby for development 9713dba
@pboling pboling Complete rewrite of `EnableButton` to ensure compatibility with all o…
…ther Rack apps
e5a9a14
@pboling pboling Removed duplicate config entry for `:verbosity` b9d2aa5
@pboling pboling Added Sinatra example to Readme 685dd77
@pboling pboling spec improvements 293838b
@pboling pboling Fixed Markdown syntax on CHANGELOG => CHANGELOG.md 7863a78
@pboling pboling bin 1625669
@pboling pboling added bin scripts, but do not include in gem package 8eee3e7
@pboling pboling gemspec cleanup 8b55353
@pboling pboling better method names 55bd9ea
@pboling pboling Bump to 0.6.0 8e0f89d
@pboling pboling Fixed gemspec 54a9c19
@pboling pboling Bump to 0.6.1 d5affc0
@pboling pboling Fixed gemspec e2c3bc7
@pboling pboling Bump to 0.6.2 a8e5445
@pboling pboling Update README.md 564e02b
@pboling pboling Coverted EnableButton to Rack::Toolbar 2d60f54
@pboling pboling Add rack-toolbar;
Add pry
67b0447
@pboling pboling Extracted Rack::Toolbar to a separate gem library;
Implement EnableButton and Toolbar with Rack::Toolbar;
Extract PathMatchFilters to mixin;
Add specs for EnableButton and Toolbar;
Remove specs that are pushed to Rack::Toolbar
7ae2106
@pboling pboling Merge branch 'master' of https://github.com/pboling/rack-insight a24dfbe
@pboling pboling More bin files f6cfdf9
@garethrees garethrees Fix Typo 5e08942
@garethrees garethrees Fix typo 79654e8
@pboling pboling Merge pull request #41 from garethrees/patch-1
Fix Typo
bcfda6c
@garethrees

Is there a better way to do this?

Every time I run a rails command I get this message, which is unnecessary.

Its also making a few of our specs fail:

Failure/Error: r.out.should == ""
       expected: ""
            got: "Could not load redis ruby gem. Some features are disabled.\n" (using ==)
       Diff:
       @@ -1 +1,2 @@
       +Could not load redis ruby gem. Some features are disabled.
@pboling

Yeah, there is a much better way. For now just removing the warn should be fine.

garethrees and others added some commits
@garethrees garethrees Remove log output when redis isn't loaded
d3cfc5a introduced a `warn` statement that prints when redis is not available.

This gets printed whenever the rails environment gets loaded (so, `rails s`,
`rails c, `rake`, etc) which is a bit annoying. The output also broke some
specs in a project that was checking the stdout of some of our
scripts.

@pboling suggested there's a better implementation in http://git.io/vfGPX
dc2dcf8
@pboling pboling Merge pull request #42 from garethrees/patch-1
Remove log output when redis isn't loaded
be04db8
@pboling pboling CHANGELOG for 0.6.3 release d5e770d
@pboling pboling Bump to 0.6.3 328ff22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.