Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad use of duplicate id on elements #43

Closed
urkle opened this issue May 19, 2015 · 1 comment
Closed

bad use of duplicate id on elements #43

urkle opened this issue May 19, 2015 · 1 comment

Comments

@urkle
Copy link

urkle commented May 19, 2015

For example using request_id_menu on several select elements does not work in modern browsers. And doing $('#request_id_menu') only selects one of them causing the dropdowns to not function most of the time. IDs on HTML elements are supposed to be unique across the entire page.. If you want multiple elements to be referenced you should use a class. e.g.

$('#rack-insight .request_id_menu')

instead

$('#request_id_menu')

@pboling
Copy link
Owner

pboling commented May 19, 2015

You are completely correct, and there is a lot of old crufty stuff there.

The HTML and JS of this project has been hardly touched since it was Rack-Bug. It needs a complete overhaul. Help is appreciated. I don't often have time to work on Rack-Insight, and when I do I focus on the back-end needs, as that is my primary expertise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants