Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applyChangesetFilterSortTarget doesn't work for sorted data when update/add records #8250

Open
chuckn0rris opened this issue Jan 12, 2024 · 3 comments
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer

Comments

@chuckn0rris
Copy link

Forum post

Open basic demo
In console

scheduler.store.applyChangeset({updated: [{id: 'r1', name : 'Adam2'}], added: [{id: 'r14', name : 'AAdam4'}] })

See sort has not been re-applied

@chuckn0rris chuckn0rris added bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer labels Jan 12, 2024
@emilschutte
Copy link

emilschutte commented Jan 13, 2024

This flag does not cause sorting in the general case. The config may need to be renamed. @bmblb what would you think about removing "sort" from this config name, since sorting is only selectively applied as needed to get any filtered-in records to appear in the right place?

@bmblb
Copy link

bmblb commented Jan 16, 2024

@emilschutte Renaming public config is problematic. We'd need to deprecate it first and then remove in the major release which would take significant time. Probably we could clarify documentation instead of renaming, explaining behavior in more details?

@emilschutte
Copy link

emilschutte commented Jan 16, 2024

@bmblb 👍 sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forum Issues from forum large-account Reported by large customer OEM OEM customer
Projects
None yet
Development

No branches or pull requests

3 participants