Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecurrenceConfirmationPopup reconfiguration should be easy #9378

Closed
ExtAnimal opened this issue Jun 13, 2024 · 0 comments
Closed

RecurrenceConfirmationPopup reconfiguration should be easy #9378

ExtAnimal opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement Functionality improvement forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@ExtAnimal
Copy link

ExtAnimal commented Jun 13, 2024

Forum post

The recurrenceConfirmationPopup config in Scheduler mixin Recurring events should be made public. It is used by drag/drop.

The RecurringEventEdit.js mixin of EventEdit should consult that config from its client when creating its own instance in addition to honouring its own recurrenceConfirmation property (That should be renamed to recurrenceConfirmationPopup, be promoted to be a configurable and made public.:

Screenshot 2024-06-13 at 16 39 42

In CalendarDrag, RecurremceConfirmationPopup instances leak because one is instantiated on every drag of an occurrence.

It needs to create only one, and pull in the recurrenceConfirmationPopup property from the client Calendar. Calendar then requires a recurrenceConfirmationPopup config.

SchedulerPro

SchedulerPro TaskEditorBase.js has

            recurrenceConfirmation = Widget.create({
                type  : 'recurrenceconfirmation',
                owner : me
                // <remove-on-release>
                // TODO: configurability?
                // ...recurrenceConfirmation
                // </remove-on-release>
            });

It should do the same. It should pull in this.client.recurrenceConfirmationPopup.initialConfig to configure the confirmation. As it stands now, it is unreconfigurable. It also leaks instances because a new one is created each time!

@ExtAnimal ExtAnimal added bug Something isn't working forum Issues from forum large-account Reported by large customer enhancement Functionality improvement high-priority Urgent to have fixed labels Jun 13, 2024
@ExtAnimal ExtAnimal added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Aug 14, 2024
@ExtAnimal ExtAnimal self-assigned this Aug 14, 2024
@ExtAnimal ExtAnimal added this to the 6.0.5 milestone Aug 14, 2024
@ExtAnimal ExtAnimal added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Functionality improvement forum Issues from forum high-priority Urgent to have fixed large-account Reported by large customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

1 participant