Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car model #18

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Car model #18

merged 9 commits into from
Jun 2, 2022

Conversation

brytebee
Copy link
Owner

@brytebee brytebee commented Jun 2, 2022

Car model

In this PR, I have achieved the following:

  • Created the Car Model.
  • Validated the Car Model.
  • Related the Car to the User Model.
  • Moved the work and related routes to the API namespace.

User has many cars
Updated migration and schema.rb, added image to car model
Moved controller into the API namespace
Moved cars into the API namespace
Cleaned
Add authorization
Copy link
Collaborator

@mugishasam123 mugishasam123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brytebee ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mugishasam123 mugishasam123 merged commit ea78b91 into develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants