Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hw-counters tests in the make check step? #108

Open
julianmorillo opened this issue Jun 19, 2024 · 0 comments
Open

Avoid hw-counters tests in the make check step? #108

julianmorillo opened this issue Jun 19, 2024 · 0 comments

Comments

@julianmorillo
Copy link
Contributor

julianmorillo commented Jun 19, 2024

Would it make sense to skip the tests in tests/functional/hw-counters in the make check process?

I believe these tests would be useful in the "production" system but are irrelevant in the "building" one. For example, one could do a build in MN5 without the need for the perfparanoid constraint in the salloc (and thus these tests would fail) but then use this very same installation without any problem once the constraint is included. So maybe removing these tests from the make check step would be a good idea (and maybe installing them in the make install process to have simple tests available in the "production" machine).

The problem comes because we are trying to add an Extrae easyconfig to the easybuild repository (see easybuilders/easybuild-easyconfigs#20690), and failing tests in the make check step are preventing the PR from being accepted.

I have already committed
3d8295c
for an XML test that was failing for the same reason, but I think adding the same hack for these hw-counters tests would make no sense as they are precisely testing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant