Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Symbol layer for Roster #43

Closed
11 of 12 tasks
amis92 opened this issue Jul 7, 2022 · 0 comments
Closed
11 of 12 tasks

Implement Symbol layer for Roster #43

amis92 opened this issue Jul 7, 2022 · 0 comments
Assignees
@amis92

Comments

@amis92
Copy link
Member

amis92 commented Jul 7, 2022 •
edited
Loading

Parts:

  • Symbols:
    • RosterSymbol
    • RosterCostSymbol
    • ForceSymbol
    • SelectionSymbol
    • RosterRuleSymbol (currently used RuleSymbol doesn't reference original Rule entry, needs ID resolution like Selection)
    • RosterProfileSymbol (currently used ProfileSymbol doesn't reference original Profile entry, needs ID resolution like Selection)
    • RosterCharacteristicSymbol (for reasons like for profile)?
  • Symbol binding:
    • CostType for RosterCostSymbol
    • ForceEntry for ForceSymbol
    • Category for special (No Category) value
amis92 added a commit that referenced this issue Jul 7, 2022
@amis92
feat: Implement Roster Selection binding, #43
12d495d
@amis92 amis92 self-assigned this Jul 7, 2022
amis92 added a commit that referenced this issue Jul 11, 2022
@amis92
feat: No Category binding, #43
b33caa6
amis92 added a commit that referenced this issue Jul 14, 2022
@amis92
feat: Roster- Profile and Rule
310e02f 
for #43

additionally:
- feat: bind EntryGroup default entry
- refactor: rename IRosterEntrySymbol to ICustomizableEntryInstanceSymbol
- refactor: rename ISelectionReferencePathSymbol to IEntryInstanceSymbol
- refactor: remove IResourceGroupSymbol, push .Resources to IEntrySymbol
- feat: create IResourceSymbol base type for roster rules and profiles
- test: add some integration tests on SampleDataset
@amis92 amis92 closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amis92 amis92

Labels
None yet
Projects
Phalanx
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amis92