Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN, MRSAS, MXGE drivers #11

Merged
merged 12 commits into from
Aug 13, 2018
Merged

Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN, MRSAS, MXGE drivers #11

merged 12 commits into from
Aug 13, 2018

Conversation

lakhanshiva
Copy link
Collaborator

@lakhanshiva lakhanshiva commented Jul 20, 2018 •
edited
Loading

No description provided.

@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachments of LE driver Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers Jul 20, 2018
@lakhanshiva lakhanshiva requested a review from bsdimp July 20, 2018 10:02
@lakhanshiva lakhanshiva self-assigned this Jul 20, 2018
lakhanshiva added a commit to lakhanshiva/freebsd that referenced this pull request Jul 20, 2018
@lakhanshiva
Add PNP info to PCI attachments of LE driver
02589c1 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY drivers Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN drivers Jul 22, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN drivers Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN, MRCSAS drivers Jul 22, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN, MRCSAS drivers Add PNP info to PCI attachments of LE, LIO, MPR, MVS, MY, MLY, MPS, MSKC, MN, MRSAS drivers Jul 22, 2018
@lakhanshiva
Add PNP info to PCI attachment of LIO driver
e7cdf71 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachments of MPR driver
7774023 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MVS driver
6b8e5b0 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachments of MY driver
c1cfaf1 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MLY driver
4767f1f 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MPS driver
96a1ebd 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MSKC driver
b95036c 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MN driver
7e997f7 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MRSAS driver
33772cc 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PNP info to PCI attachment of MXGE driver
85d6c1e 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@lakhanshiva
Add PCI_SUBDEVICE macro
73cf757 
Reviewed by: imp, chuck
Only subdevice is matched (not subvendor)
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: bsdimp#11
Url: https://reviews.freebsd.org/D16363
@bsdimp bsdimp merged commit 86ff578 into bsdimp:lakhan-pnpinfo-3 Aug 13, 2018
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachments of LE driver
9cd9eca 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of LIO driver
d5f4b36 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachments of MPR driver
83c2268 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MVS driver
5d066b7 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachments of MY driver
d47efba 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MLY driver
52ef8b0 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MPS driver
c033bf4 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MSKC driver
6d10412 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MN driver
7fe95dd 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MRSAS driver
1b4da78 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request Aug 13, 2018
@lakhanshiva @bsdimp
Add PNP info to PCI attachment of MXGE driver
a35e351 
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #11
Url: https://reviews.freebsd.org/D16363
bsdimp pushed a commit that referenced this pull request May 10, 2023
@rob-wing
FreeBSD: don't verify recycled vnode for zfs control directory
28251d8 
Under certain loads, the following panic is hit:

    panic: page fault
    KDB: stack backtrace:
    #0 0xffffffff805db025 at kdb_backtrace+0x65
    #1 0xffffffff8058e86f at vpanic+0x17f
    #2 0xffffffff8058e6e3 at panic+0x43
    #3 0xffffffff808adc15 at trap_fatal+0x385
    #4 0xffffffff808adc6f at trap_pfault+0x4f
    #5 0xffffffff80886da8 at calltrap+0x8
    #6 0xffffffff80669186 at vgonel+0x186
    #7 0xffffffff80669841 at vgone+0x31
    #8 0xffffffff8065806d at vfs_hash_insert+0x26d
    #9 0xffffffff81a39069 at sfs_vgetx+0x149
    #10 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #11 0xffffffff8065a28c at lookup+0x45c
    #12 0xffffffff806594b9 at namei+0x259
    #13 0xffffffff80676a33 at kern_statat+0xf3
    #14 0xffffffff8067712f at sys_fstatat+0x2f
    #15 0xffffffff808ae50c at amd64_syscall+0x10c
    freebsd#16 0xffffffff808876bb at fast_syscall_common+0xf8

The page fault occurs because vgonel() will call VOP_CLOSE() for active
vnodes. For this reason, define vop_close for zfsctl_ops_snapshot. While
here, define vop_open for consistency.

After adding the necessary vop, the bug progresses to the following
panic:

    panic: VERIFY3(vrecycle(vp) == 1) failed (0 == 1)
    cpuid = 17
    KDB: stack backtrace:
    #0 0xffffffff805e29c5 at kdb_backtrace+0x65
    #1 0xffffffff8059620f at vpanic+0x17f
    #2 0xffffffff81a27f4a at spl_panic+0x3a
    #3 0xffffffff81a3a4d0 at zfsctl_snapshot_inactive+0x40
    #4 0xffffffff8066fdee at vinactivef+0xde
    #5 0xffffffff80670b8a at vgonel+0x1ea
    #6 0xffffffff806711e1 at vgone+0x31
    #7 0xffffffff8065fa0d at vfs_hash_insert+0x26d
    #8 0xffffffff81a39069 at sfs_vgetx+0x149
    #9 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #10 0xffffffff80661c2c at lookup+0x45c
    #11 0xffffffff80660e59 at namei+0x259
    #12 0xffffffff8067e3d3 at kern_statat+0xf3
    #13 0xffffffff8067eacf at sys_fstatat+0x2f
    #14 0xffffffff808b5ecc at amd64_syscall+0x10c
    #15 0xffffffff8088f07b at fast_syscall_common+0xf8

This is caused by a race condition that can occur when allocating a new
vnode and adding that vnode to the vfs hash. If the newly created vnode
loses the race when being inserted into the vfs hash, it will not be
recycled as its usecount is greater than zero, hitting the above
assertion.

Fix this by dropping the assertion.

FreeBSD-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252700
Reviewed-by: Andriy Gapon <avg@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Rob Wing <rob.wing@klarasystems.com>
Co-authored-by: Rob Wing <rob.wing@klarasystems.com>
Submitted-by: Klara, Inc.
Sponsored-by: rsync.net
Closes #14501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsdimp bsdimp bsdimp approved these changes

Assignees

@lakhanshiva lakhanshiva

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lakhanshiva @bsdimp