Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers #6

Merged
merged 10 commits into from
Jul 8, 2018

Conversation

lakhanshiva
Copy link
Collaborator

@lakhanshiva lakhanshiva commented Jun 13, 2018

The device id table for hptiop is

static struct hptiop_dev {
	uint16_t vendorid;
	uint16_t deviceid;
	const char *description;
	struct hptiop_adapter_ops *ops;
} hptiop_devs[]

Therefore i used "U16:vendor;U16:device" as description string in PNP_INFO

The device id table for arcmsr is

static struct arcmsr_dev {
	uint16_t vendorid;
	uint32_t deviceid;
	uint16_t subdeviceid;
	char *description;
} arcmsr_devs[]

Therefore i used "U16:vendor;U32:device;U16:subdevice" as description string in PNP_INFO

The device table of hifn is

static struct hifn_dev {
        uint16_t vendorid;
        uint16_t deviceid;
} hifn_devs[]

Therefore i used "U16:vendor;U16:device" as description string in PNP_INFO

The device id table of bt driver is

static struct bt_dev {
        uint16_t vendorid;
	uint32_t deviceid;
	const char *description;
} bt_devs[]

Therefore i used "U16:vendor;U32:device" as description string in PNP_INFO

The device id table of snd_emu10k1 (emu_pci)

static struct emu_pci_dev {
	uint16_t vendorid;
	uint32_t deviceid;
	uint8_t rev;
	const char *description;
} emu_pci_devs[]

Therefore i used "U16:vendor;U32:device" as description string in PNP_INFO

The device id table for emujoy driver is

static struct emujoy_pci_dev {
	uint16_t vendorid;
	uint32_t deviceid;
	const char *description;
} emujoy_pci_devs[]

Therefore i used "U16:vendor;U32:device" as description string in PNP_INFO

The device table of ebus is

static struct ebus_pci_dev {
	uint16_t vendorid;
	uint16_t deviceid;
	const char *description;
} ebus_pci_devs[]

Therefore i used "U16:vendor;U16:device" as description string in PNP_INFO

The device id table for cbb driver is

static struct yenta_chipinfo {
	uint32_t yc_id;
	const	char *yc_name;
	int	yc_chiptype;
} yc_chipsets[]

Therefore i used "W32:vendor/device" as the description string in PNP_INFO
The device id table for de driver is

static struct de_dev {
	uint16_t vendorid;
	uint16_t deviceid;
	uint8_t revid;
	const char *description;
}

Therefore i used "U16:vendor;U16:device" as description string in PNP_INFO

The device id table for fixup_pci driver is

static struct fixup_pci_dev {
	uint32_t devid;
	const char *description;
} fixup_pci_devs[]

Therefore i used "W32:vendor/device" as the description string in PNP_INFO

The device id table for imcsmb driver is

static struct imcsmb_pci_device {
	uint16_t	vendorid;
        uint16_t	deviceid;
	char		*name;
} imcsmb_pci_devices[]

Therefore i used "U16:vendor;U16:device" as the description string in PNP_INFO

@lakhanshiva lakhanshiva self-assigned this Jun 13, 2018
@lakhanshiva lakhanshiva requested a review from bsdimp June 13, 2018 16:58
@lakhanshiva lakhanshiva force-pushed the lakhan-pnpinfo-3 branch 2 times, most recently from 4b8ef30 to d09c701 Compare June 13, 2018 18:12
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of hptiop driver Add PNP info to PCI attachment of arcmsr, hptiop driver Jun 13, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, hptiop driver Add PNP info to PCI attachment of arcmsr, hptiop drivers Jun 13, 2018
@lakhanshiva lakhanshiva force-pushed the lakhan-pnpinfo-3 branch 4 times, most recently from 221767e to d1cd2dd Compare June 14, 2018 12:55
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, hptiop drivers Add PNP info to PCI attachment of arcmsr, hifn, hptiop drivers Jun 14, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, hifn, hptiop drivers Add PNP info to PCI attachment of arcmsr, bt, hifn, hptiop drivers Jun 14, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, bt, hifn, hptiop drivers Add PNP info to PCI attachment of arcmsr, bt, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Jun 14, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, bt, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Add PNP info to PCI attachment of arcmsr, bt, ebus, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Jun 14, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, bt, ebus, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Add PNP info to PCI attachment of arcmsr, bt, cbb, ebus, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Jun 17, 2018
@lakhanshiva lakhanshiva changed the title Add PNP info to PCI attachment of arcmsr, bt, cbb, ebus, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, hifn, hptiop, snd_emu10k1 (emu_pci) drivers Jun 17, 2018
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request Jul 8, 2018
Reviewed by: imp, chuck
Submitted by: Lakhan Shiva Kamireddy <lakhanshiva@gmail.com>
Sponsored by: Google, Inc. (GSoC 2018)
Pull Request: #6
Url: https://reviews.freebsd.org/D15996
bsdimp pushed a commit that referenced this pull request May 10, 2023
Under certain loads, the following panic is hit:

    panic: page fault
    KDB: stack backtrace:
    #0 0xffffffff805db025 at kdb_backtrace+0x65
    #1 0xffffffff8058e86f at vpanic+0x17f
    #2 0xffffffff8058e6e3 at panic+0x43
    #3 0xffffffff808adc15 at trap_fatal+0x385
    #4 0xffffffff808adc6f at trap_pfault+0x4f
    #5 0xffffffff80886da8 at calltrap+0x8
    #6 0xffffffff80669186 at vgonel+0x186
    #7 0xffffffff80669841 at vgone+0x31
    #8 0xffffffff8065806d at vfs_hash_insert+0x26d
    #9 0xffffffff81a39069 at sfs_vgetx+0x149
    #10 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #11 0xffffffff8065a28c at lookup+0x45c
    #12 0xffffffff806594b9 at namei+0x259
    #13 0xffffffff80676a33 at kern_statat+0xf3
    #14 0xffffffff8067712f at sys_fstatat+0x2f
    #15 0xffffffff808ae50c at amd64_syscall+0x10c
    freebsd#16 0xffffffff808876bb at fast_syscall_common+0xf8

The page fault occurs because vgonel() will call VOP_CLOSE() for active
vnodes. For this reason, define vop_close for zfsctl_ops_snapshot. While
here, define vop_open for consistency.

After adding the necessary vop, the bug progresses to the following
panic:

    panic: VERIFY3(vrecycle(vp) == 1) failed (0 == 1)
    cpuid = 17
    KDB: stack backtrace:
    #0 0xffffffff805e29c5 at kdb_backtrace+0x65
    #1 0xffffffff8059620f at vpanic+0x17f
    #2 0xffffffff81a27f4a at spl_panic+0x3a
    #3 0xffffffff81a3a4d0 at zfsctl_snapshot_inactive+0x40
    #4 0xffffffff8066fdee at vinactivef+0xde
    #5 0xffffffff80670b8a at vgonel+0x1ea
    #6 0xffffffff806711e1 at vgone+0x31
    #7 0xffffffff8065fa0d at vfs_hash_insert+0x26d
    #8 0xffffffff81a39069 at sfs_vgetx+0x149
    #9 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #10 0xffffffff80661c2c at lookup+0x45c
    #11 0xffffffff80660e59 at namei+0x259
    #12 0xffffffff8067e3d3 at kern_statat+0xf3
    #13 0xffffffff8067eacf at sys_fstatat+0x2f
    #14 0xffffffff808b5ecc at amd64_syscall+0x10c
    #15 0xffffffff8088f07b at fast_syscall_common+0xf8

This is caused by a race condition that can occur when allocating a new
vnode and adding that vnode to the vfs hash. If the newly created vnode
loses the race when being inserted into the vfs hash, it will not be
recycled as its usecount is greater than zero, hitting the above
assertion.

Fix this by dropping the assertion.

FreeBSD-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252700
Reviewed-by: Andriy Gapon <avg@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Rob Wing <rob.wing@klarasystems.com>
Co-authored-by: Rob Wing <rob.wing@klarasystems.com>
Submitted-by: Klara, Inc.
Sponsored-by: rsync.net
Closes #14501
bsdimp pushed a commit that referenced this pull request Aug 16, 2023
Avoid locking issues when if_allmulti() calls the driver's if_ioctl,
because that may acquire sleepable locks (while we hold a non-sleepable
rwlock).

Fortunately there's no pressing need to hold the mroute lock while we
do this, so we can postpone the call slightly, until after we've
released the lock.

This avoids the following WITNESS warning (with iflib drivers):

	lock order reversal: (sleepable after non-sleepable)
	 1st 0xffffffff82f64960 IPv4 multicast forwarding (IPv4 multicast forwarding, rw) @ /usr/src/sys/netinet/ip_mroute.c:1050
	 2nd 0xfffff8000480f180 iflib ctx lock (iflib ctx lock, sx) @ /usr/src/sys/net/iflib.c:4525
	lock order IPv4 multicast forwarding -> iflib ctx lock attempted at:
	#0 0xffffffff80bbd6ce at witness_checkorder+0xbbe
	#1 0xffffffff80b56d10 at _sx_xlock+0x60
	#2 0xffffffff80c9ce5c at iflib_if_ioctl+0x2dc
	#3 0xffffffff80c7c395 at if_setflag+0xe5
	#4 0xffffffff82f60a0e at del_vif_locked+0x9e
	#5 0xffffffff82f5f0d5 at X_ip_mrouter_set+0x265
	#6 0xffffffff80bfd402 at sosetopt+0xc2
	#7 0xffffffff80c02105 at kern_setsockopt+0xa5
	#8 0xffffffff80c02054 at sys_setsockopt+0x24
	#9 0xffffffff81046be8 at amd64_syscall+0x138
	#10 0xffffffff8101930b at fast_syscall_common+0xf8

See also:	https://redmine.pfsense.org/issues/12079
Reviewed by:	mjg
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D41209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants