Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pot info -E lacks generates code lacking the required quoting #95

Closed
Crest opened this issue Jun 24, 2020 · 0 comments · Fixed by #96
Closed

[BUG] Pot info -E lacks generates code lacking the required quoting #95

Crest opened this issue Jun 24, 2020 · 0 comments · Fixed by #96
Labels

Comments

@Crest
Copy link
Contributor

Crest commented Jun 24, 2020

Describe the bug
The internal helper pot info -E -p $pot generates code lacking the quoting required to assign multiple words to a single variable.

To Reproduce
Steps to reproduce the behavior:

  1. Create the pot with this command: pot create -v -p test -f fbsd-update -t single -N alias -S dual -i 'em0|2001:db8::2' -i 'lo0|127.0.0.2' -b 12.1
  2. Run this command: pot info -E -p test
  3. See error

Expected behavior
I expected this output from pot info -E -p test:

export _POT_NAME=test
export _POT_IP=127.0.0.2
export _POT_IP_0=127.0.0.2
export _POT_NIC_0=lo0
export _POT_IP_1=2001:db8::2
export _POT_NIC_1=em0
export _POT_IP_LIST=_POT_IP_0\ _POT_IP_1
export _POT_NIC_LIST=_POT_NIC_0\ _POT_NIC_1

instead I got this output:

export _POT_NAME=test
export _POT_IP=127.0.0.2
export _POT_IP_0=127.0.0.2
export _POT_NIC_0=lo0
export _POT_IP_1=2001:db8::2
export _POT_NIC_1=em0
export _POT_IP_LIST=_POT_IP_0 _POT_IP_1
export _POT_NIC_LIST=_POT_NIC_0 _POT_NIC_1

Please note the missing \ between the list elements.

Additional context
This bug prevents hooks from working correctly for multi address pots. Multiple addresses are required for dual stack operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant