[EXP] Undo sphinx-gallery hack #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passed! So I suggest to remove the hack for now, but keep an eye on the sphinx-gallery releases, and whenever your fix gets in a release, revise the version number requirement in the matrix. |
|
Okay, I opened astropy#6266 so we don't forget about it. Thanks! |
bsipocz
pushed a commit
that referenced
this pull request
May 16, 2018
Don't serialize format as it is now managed with the fits code
bsipocz
pushed a commit
that referenced
this pull request
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
This is to see if the Travis hack is really necessary for doc build to pass. The test should kick off on my fork.
UPDATE: Oh, you have Travis set up here too. Let's just look at this one then.