-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulate reconfigure on Python 3.6 and lower #33
Comments
Maybe upstream this to |
<nod>, I hadn't realized how much less important the encodings were for mocks like this, as compared to the real streams. Seems like classifying this for now as YAGNI is the best approach -- as you say, only worrying about implementation if a future user needs it. |
We may run into problem with pytest, due to pytest-dev/pytest#4843 and pytest-dev/pytest#4389 |
Current code at https://github.com/python/cpython/blob/c4cacc8/Lib/_pyio.py#L2118 . It looks like most of it should be fairly easy to backport, except that I cant find an existing backport in future, and it looks way beyond scope for six. https://github.com/ipython/ipykernel/blob/master/ipykernel/iostream.py is a rewrite, which they apparently want to keep in sync with the wrapper class ipython/ipykernel#178 . |
Created PythonCharmers/python-future#498 for adding backport there |
With 3.6 now firmly EOL, not going to bother with this. |
Im not sure how much effort is required, but if the streams have a
.reconfigure
then the context manager constructor doesnt need to have lots of arguments for possible configurations of the stream.The text was updated successfully, but these errors were encountered: