Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors importing upstream nall into bsnes repository #202

Open
carmiker opened this issue Aug 1, 2021 · 0 comments
Open

Errors importing upstream nall into bsnes repository #202

carmiker opened this issue Aug 1, 2021 · 0 comments

Comments

@carmiker
Copy link
Contributor

carmiker commented Aug 1, 2021

When attempting to import the upstream nall repository into bsnes, a large number of errors occur at compile time.

Although there is quite an onslaught of error text, it all boils down to just two errors repeating many times, all in target-bsnes/program/platform.cpp, target-bsnes/program/program.cpp, target-bsnes/program/game-pak.cpp. and target-bsnes/program/game-rom.cpp:

target-bsnes/program/platform.cpp: In member function 'virtual nall::shared_pointer<nall::vfs::file> Program::open(uint, nall::string, nall::vfs::file::mode, bool)':
target-bsnes/program/platform.cpp:15:35: error: 'open' is not a member of 'nall::vfs::file'
   15 |       result = vfs::memory::file::open(Resource::System::Boards, sizeof(Resource::System::Boards));
target-bsnes/program/game-pak.cpp: In member function 'nall::shared_pointer<nall::vfs::file> Program::openPakSuperFamicom(nall::string, nall::vfs::file::mode)':
target-bsnes/program/game-pak.cpp:2:15: error: 'nall::vfs::fs' has not been declared
    2 |   return vfs::fs::file::open({superFamicom.location, name}, mode);

The solution to this is not obvious to me. Perhaps someone with a deeper understanding of bsnes and nall can offer some insight and lead the way to the most correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant