-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make constant values for use with the default image parameter #24
Labels
enhancement
New feature or request
Comments
bsoyka
added
enhancement
New feature or request
help wanted
Extra attention is needed
good first issue
Good for newcomers
hacktoberfest
Recommended for https://hacktoberfest.digitalocean.com/
labels
Oct 5, 2019
Hey @bsoyka, I can take it. What do you think about using
Usage
instead of
Usage
|
Hey, @mfaheemakhtar! I like your idea! A couple small changes, let me know your thoughts: DEFAULT_IMAGES = {
'404': '404',
'mystery_person': 'mp',
'identicon': 'identicon',
'monsterid': 'monsterid',
'wavatar': 'wavatar',
'retro': 'retro',
'robohash': 'robohash',
'blank': 'blank'
} Also, when you make your PR, make sure you add a test or two to make sure it works. |
bsoyka
removed
good first issue
Good for newcomers
hacktoberfest
Recommended for https://hacktoberfest.digitalocean.com/
help wanted
Extra attention is needed
labels
Oct 5, 2019
Hey @bsoyka , how do you run unit tests?
|
You can run the tests with this:
|
Closed via #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Take a look at @charanjit-singh's comment here.
There are 8 different constants that need to be added in some way, and you can see them here.
Please comment if you'd like to work on this, and make a pull request to the
development
branch.The text was updated successfully, but these errors were encountered: