Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small corrections after v1.0 #42

Open
2 of 4 tasks
donotdespair opened this issue Jul 24, 2024 · 0 comments
Open
2 of 4 tasks

small corrections after v1.0 #42

donotdespair opened this issue Jul 24, 2024 · 0 comments

Comments

@donotdespair
Copy link
Member

donotdespair commented Jul 24, 2024

Hey @adamwang15,

I'm looking at our package and we need to improve some things:

  • update @references in documentation for estimate.BSVARSIGN
  • @adamwang15 I'm looking at the code below
spec$prior$estimate_hyper (mu = TRUE, delta = TRUE, lambda = TRUE, psi = TRUE)

and I think we should make this possible by running

spec$estimate_hyper (mu = TRUE, delta = TRUE, lambda = TRUE, psi = TRUE)

or both should be possible 😸

  • Shall we update the example in specify_narrative() so that the current one:
specify_narrative(start = 166, periods = 1, type = "S", sign = 1, shock = 1, var = 6)

was used in context:

narrative = specify_narrative(start = 166, periods = 1, type = "S", sign = 1, shock = 1, var = 6)
specification  = specify_bsvarSIGN$new(monetary, sign_narrative = list(narrative))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants