Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textureGather's description is wrong #48

Closed
NicolBolas opened this issue Jan 5, 2017 · 2 comments
Closed

textureGather's description is wrong #48

NicolBolas opened this issue Jan 5, 2017 · 2 comments

Comments

@NicolBolas
Copy link

The website says this:

vec4(Sample_i0_j1(P, base).comp,
     Sample_i1_j1(P, base).comp,
     Sample_i1_j0(P, base).comp,
     Sample_i0_j1(P, base).comp);

But the GLSL specification says this:

vec4(Sample_i0_j1(P, base).comp,
     Sample_i1_j1(P, base).comp,
     Sample_i1_j0(P, base).comp,
     Sample_i0_j0(P, base).comp);

Note the last one, with the 0,0 i,j value.

This mistake is also in the textureGatherOffset and textureGatherOffsets functions.

@BSVino
Copy link
Owner

BSVino commented Jan 6, 2017

Care to make a PR?

@leumasme
Copy link
Contributor

Why is this issue still open if the closing PR has been merged?

@BSVino BSVino closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants