-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use parameter object as argument of Start() function in PostgresRunner #15
Comments
marcinbudny
added a commit
that referenced
this issue
Feb 3, 2018
This was referenced Feb 3, 2018
marcinbudny
added a commit
that referenced
this issue
Feb 3, 2018
zabrowarnyrafal
added a commit
that referenced
this issue
Feb 4, 2018
* Prepared working solution of Postgres that can be used with integration tests (#1) * PortWatcher implementation * PostgresBinaryLocator implementation * Move code one level up in repo * PostgresRunner implementation * Introduced Postgresinitializator process starter; throw exception when process return error code; bum dotnet standard to v2.0; setup basic test * distinguish pg executables based on os platform; fix long polling of free tcp port * Added missed binaries of postgres (3 os platforms supported by net core) * Updated linux based postgres binaries * Provided sample test suit how to execute pgrunner inside of xunit class fixture * Removed OSX binaries; OSX as OS Platform won't be supported till issue of it binaries size will be resolved * Fix Postgres Runner disposable procedure -there are no more thrown exception nor custom finalization; Postgres server start process is not disposable anymore cause it is one time call to pg_ctrl; Postgres server stop process is not throwing exceptions anymore - it should report only own output buffer; * Added possibility so specify database which will be used to build connection string * PostgresRunner doesn't use try/catch block in constructor anymore; instead Start() function is responsible for constructing and preparing running PostgresRunner instance; in case when running Postgres failed then PostgresRunner instance should be disposed. * Provided xunit.runner.visualstudio to Postgres2Go.Samples so tests can be run directly from IDE (vs or rider) * Corrected licensing (#18) Corrected licensing * #15 use options object in PostgresRunner API * #15 use options object in PostgresRunner API
zabrowarnyrafal
pushed a commit
to zabrowarnyrafal/Postgres2Go
that referenced
this issue
Feb 7, 2018
zabrowarnyrafal
pushed a commit
to zabrowarnyrafal/Postgres2Go
that referenced
this issue
Feb 7, 2018
zabrowarnyrafal
added a commit
to zabrowarnyrafal/Postgres2Go
that referenced
this issue
Feb 9, 2018
* PortWatcher implementation * PostgresBinaryLocator implementation * Move code one level up in repo * PostgresRunner implementation * Introduced Postgresinitializator process starter; throw exception when process return error code; bum dotnet standard to v2.0; setup basic test * distinguish pg executables based on os platform; fix long polling of free tcp port * Added missed binaries of postgres (3 os platforms supported by net core) * Updated linux based postgres binaries * Provided sample test suit how to execute pgrunner inside of xunit class fixture * Removed OSX binaries; OSX as OS Platform won't be supported till issue of it binaries size will be resolved * Fix Postgres Runner disposable procedure -there are no more thrown exception nor custom finalization; Postgres server start process is not disposable anymore cause it is one time call to pg_ctrl; Postgres server stop process is not throwing exceptions anymore - it should report only own output buffer; * Added possibility so specify database which will be used to build connection string * PostgresRunner doesn't use try/catch block in constructor anymore; instead Start() function is responsible for constructing and preparing running PostgresRunner instance; in case when running Postgres failed then PostgresRunner instance should be disposed. * Provided xunit.runner.visualstudio to Postgres2Go.Samples so tests can be run directly from IDE (vs or rider) * Prepared working solution of Postgres that can be used with integration tests (#1) * PortWatcher implementation * PostgresBinaryLocator implementation * Move code one level up in repo * PostgresRunner implementation * Introduced Postgresinitializator process starter; throw exception when process return error code; bum dotnet standard to v2.0; setup basic test * distinguish pg executables based on os platform; fix long polling of free tcp port * Added missed binaries of postgres (3 os platforms supported by net core) * Updated linux based postgres binaries * Provided sample test suit how to execute pgrunner inside of xunit class fixture * Removed OSX binaries; OSX as OS Platform won't be supported till issue of it binaries size will be resolved * Fix Postgres Runner disposable procedure -there are no more thrown exception nor custom finalization; Postgres server start process is not disposable anymore cause it is one time call to pg_ctrl; Postgres server stop process is not throwing exceptions anymore - it should report only own output buffer; * Added possibility so specify database which will be used to build connection string * PostgresRunner doesn't use try/catch block in constructor anymore; instead Start() function is responsible for constructing and preparing running PostgresRunner instance; in case when running Postgres failed then PostgresRunner instance should be disposed. * Provided xunit.runner.visualstudio to Postgres2Go.Samples so tests can be run directly from IDE (vs or rider) * Provided information about license. Tools folder includes now PostgreSQL license. Updated readme file with section describing license. * Prepared cake build script; moved postgres distributions from tools/ folder pg-dist as tools/ folder is used by cake build system * Removed net 4.6.2 target from tests project as it is not supported on linux; fix cake bootstraper script missing executable mode on linux; moved postgres distrbuted files to pg-dist (only linux distribution) * Updated README.md Changed information about postgres distributions due moving them to pg-dist folder * bt-skyrise#15 use options object in PostgresRunner API * bt-skyrise#15 use options object in PostgresRunner API * Added gitversion to generate semver for each build; for each build sermver is applied to generated assemblies and packages * Appveyor setup
zabrowarnyrafal
added a commit
that referenced
this issue
Feb 14, 2018
…ckage Merge release/0.2.0-publish-nuget-package * #15 use options object in PostgresRunner API * #5 Added Cake build script (#23) * #7 Added Appveyor CI configuration (#24) * #10 Fix broken linux pg distribution (#28) * Added release,hotfix branches to CI build * Appveyor - verbose logging of gitversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead of multiple arguments we could use just 1 object grouping all required and optional parameters
The text was updated successfully, but these errors were encountered: