Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7 Added Appveyor CI configuration #24

Merged
merged 3 commits into from
Feb 11, 2018
Merged

#7 Added Appveyor CI configuration #24

merged 3 commits into from
Feb 11, 2018

Conversation

zabrowarnyrafal
Copy link
Member

No description provided.

@marcinbudny
Copy link
Contributor

My suggestion is to push packages built from develop and feature branches to a dedicated myget feed. Packages built from a tag on master can be either pushed automatically to nuget.org or they can be moved from myget to nuget.org by hand.

Setup deploys to nuget.org feed, github release; use gitversion outpu…
c2a16e5 
…t to proper tag appvoyer build, github release, github tag
@zabrowarnyrafal
Copy link
Member Author

Done:

  • setup for automatically creation of github release draft (no artifacts; we should include release notes)
  • setup for deploy to nuget.org feed

@marcinbudny
Copy link
Contributor

What about the myget prerelease deploys?
What about deploying nuget package only for tags on master?

@zabrowarnyrafal
Copy link
Member Author

Now each accepted change on master means 'ready to install' version (tagged & release draft); it is stable version (according to version number) - IMO this is enough for now. We follow gitflow workflow so direct commits to master are forbidden (we must set apropriate policies in GH branch settings ) and with support/ release/ hotfix/ branche we have staging phase when we can check quality of changes. IMO there will be no commits on master without tags so we also not need 'only for tag commits' appveyor setting.

Regarding prerelease packages - IMO we should only publish those which origin from release/support/hotfix branches (-beta prefixed).
I was considering if myget feed is needed as appveyor provide also feed for published artifacts; if You still thinking that myget feed usgae would be better, please right comment below confirming it and then I will prepare another deploy for beta channel

@marcinbudny
Copy link
Contributor

Prerelease also means new features. But we can skip this for now as you suggest.

@marcinbudny
Copy link
Contributor

Do we also build the PRs? We need that and also enable a check on PR to have a successful build.

@zabrowarnyrafal
Copy link
Member Author

PR build is enabled; right, no successful build no merge possibility - i'll manage it

@zabrowarnyrafal zabrowarnyrafal merged commit 37ad72a into develop Feb 11, 2018
@zabrowarnyrafal zabrowarnyrafal deleted the feature/7-setup-ci branch February 11, 2018 21:47
@zabrowarnyrafal zabrowarnyrafal mentioned this pull request Feb 13, 2018
Merged
zabrowarnyrafal added a commit that referenced this pull request Feb 14, 2018
@zabrowarnyrafal
Merge pull request #30 from bt-skyrise/release/0.2.0-publish-nuget-pa…
8ab35e7 
…ckage

Merge release/0.2.0-publish-nuget-package

* #15 use options object in PostgresRunner API
* #5 Added Cake build script (#23)
* #7 Added Appveyor CI configuration (#24)
* #10 Fix broken linux pg distribution (#28)
* Added release,hotfix branches to CI build
* Appveyor - verbose logging of gitversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinbudny marcinbudny marcinbudny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zabrowarnyrafal @marcinbudny