Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was a little convoluted, and I think this is an appropriate fix.
Essentially the issue is primarily with the way this module is calling the chimp executable. According to the documentation located here tags need to be passed in 2 ways. If we want to AND tags together, we need to have
--tag=@tagname --tag=@tagname2
where as if we want to OR:--tag=@tagname,@tagname2
This chimp module grabs the pre-formatted arguments. So if we pass it an array, the translation is the following:
tags: ['@tag1', '@tag2'] ~> '@tag1,@tag2'
which isn't want we want all the time. So this fix allows you to pass an array of tags to support so if you want @tag1 AND @tag2 OR @tag3 we would pass:tags: JSON.stringify(['@tag1', '@tag2,@tag3'])
This does not break any functional code, so if people pass in
tags: '@tag1,tag2'
it will work fine.I have changed your test grunt file to accomidate and demonstrate these changes, i recommend you start the code review there.
![image](https://user-images.githubusercontent.com/3287572/27592010-6af5e036-5b21-11e7-96bb-3c8d7d060453.png)