Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcd.conf does not respect ; comments #135

Closed
carryforward opened this issue Jun 8, 2014 · 1 comment
Closed

btcd.conf does not respect ; comments #135

carryforward opened this issue Jun 8, 2014 · 1 comment

Comments

@carryforward
Copy link
Contributor

The sample-btcd.conf file is provided in the source code in the btcd directory. If a comment is placed at the end of the line of a valid setting, the btcd parser will interpret the comment as a setting.

with btcd.conf setting of:

listen=:8333          ; all interfaces on port 8333

example error message:

19:34:03 2014-06-08 [WRN] SRVR: Can't listen on :8333          ; all interfaces on port 8333: listen tcp4: unknown port tcp4/8333          ; all interfaces on port 8333

If a semicolon can be a valid entry in a setting, the perhaps modifying the sample-btcd.conf file is all that is needed. If a semicolon is never valid, or needs separate escaping, trimming at the ; may be all that is needed.

@davecgh
Copy link
Member

davecgh commented Jun 9, 2014

Good point. The ini config parser that is part of the go-flags package doesn't handle them at the end of the line. Either a pull request to the upstream go-flags should be provided to allow this or the sample config file should be changed to not show the examples with trailing comments like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants