Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Makefile, use golangci-lint, parallelize CI actions #206

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

guggero
Copy link
Contributor

@guggero guggero commented Sep 27, 2021

Some optimizations to the CI pipeline to make the project more similar to btcwallet.

cc @Roasbeef.

@Roasbeef
Copy link
Member

The coverage test is failing:

/home/runner/work/_actions/shogo82148/actions-goveralls/v1/bin/goveralls_linux_amd64 -service=github -coverprofile=profile.txt
error parsing coverage: open profile.txt: no such file or directory
Error: Error: The process '/home/runner/work/_actions/shogo82148/actions-goveralls/v1/bin/goveralls_linux_amd64' failed with exit code 1

Is that just becuase we haven't set up coveralls itself on this repo yet?

With this commit we add a Makefile with the goal of removing the
goclean.sh script. We also use the more powerful golangci-lint linter
and split the GitHub actions into multiple sections to parallelize them.
@guggero
Copy link
Contributor Author

guggero commented Sep 28, 2021

Is that just becuase we haven't set up coveralls itself on this repo yet?

No, the file name of the coverage report changed from profile.txt to coverage.txt. Fixed and seems to be working now 🎉

@guggero
Copy link
Contributor Author

guggero commented Nov 29, 2021

Ping @Roasbeef, cc @positiveblue.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐉

@Roasbeef Roasbeef merged commit 9c4bbab into btcsuite:master Nov 29, 2021
@guggero guggero deleted the makefile branch November 29, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants