Module Support: complete implementation #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
module-support-complete
branch
from
9bb00e7
to
ea564ff
Compare
|
Here you go, version 1.2.0: |
rwaldron
force-pushed
the
module-support-complete
branch
11 times, most recently
from
40bd77f
to
c3b9352
Compare
|
Fully green with both module and dynamic imports tests. I feel good enough about this to land now. Unfortunately, I'm completely blocked by this feature and need to move forward. |
rwaldron
force-pushed
the
module-support-complete
branch
4 times, most recently
from
5299e1d
to
c5af48b
Compare
- Many tests directly from test262 (count of files that are not _FIXTURE.js) - Out of the box support: V8, SpiderMonkey, JavaScriptCore and Moddable XS
rwaldron
force-pushed
the
module-support-complete
branch
from
c5af48b
to
ca5a8fd
Compare
|
I've opened an issue with ChakraCore requesting a new |
|
Is this available through Note that both V8 and JSC automatically enable the module goal for any files whose name ends with |
|
@mathiasbynens I've just assigned your request to myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
224A whole bunch of tests directly from test262 (count of files that are not _FIXTURE.js)This is blocked by test262-stream (which just needs to be released)