Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plug-able annotation system #61

Closed
wants to merge 2 commits into from
Closed

Conversation

mlegenhausen
Copy link

I add the possibility to extend ngmin with annotation packages which are prefixed with astral-angular-annotate-. One extension can be found here https://github.com/werk85/astral-angular-annotate-ng-route. This adds resolve support to the ngRoute annotations.

The target of this pull request is to make ngmin more open and allow external angular libraries to provide their own annotations. This would resolve many issues here in the issue tracker. Also would it be possible for the angular team to split up their annotations in separate packages.

This is not finished yet, but it would be nice to get some feedback.

Thanks to @sindresorhus who inspired me to this implementation.

@szimek
Copy link

szimek commented Nov 20, 2013

👍

@mlegenhausen
Copy link
Author

Ok the Travis build failed cause astral-angular-annotate-ng-route is not avaibale on npm.

@maxbates
Copy link

would greatly appreciate this!

@tlvince
Copy link

tlvince commented Dec 4, 2013

Looks promising 👍 Thoughts on this @btford?

@planmanager
Copy link

Please support minification of $routeProvider resolve functions

@alonisser
Copy link

+1

2 similar comments
@mb-dev
Copy link

mb-dev commented Jan 31, 2014

+1

@philippd
Copy link

+1

@btford
Copy link
Owner

btford commented Mar 3, 2014

I need to fix up some things, but I'd be happy to add this.

@mlegenhausen
Copy link
Author

Thats nice to hear :) I would provide some ui-router annotations cause these seem the most requested ones and we need them too. Would you be happy with the astral-angular-annotate- prefix or something more like ngmin-annotate- or only ngmin-?

I will add documentation for plugin creation.

@mlegenhausen
Copy link
Author

I created some ui-router annotations for demonstration purpose, these are currently untested. I will try them out in the next days.

https://github.com/werk85/astral-angular-annotate-ui-router

@luisfarzati
Copy link

+1

@rahim
Copy link

rahim commented Mar 17, 2014

+1

1 similar comment
@gotvitch
Copy link

+1

tlvince added a commit to tlvince/LMIS-Chrome that referenced this pull request Apr 1, 2014
@noducks
Copy link

noducks commented Apr 4, 2014

+1

@kosmotaur
Copy link

👍

@eddiemonge
Copy link
Collaborator

ngmin is now deprecated: #93

Maybe make sure ng-annotate supports something like this and if not, get a pr there for this?

@eddiemonge eddiemonge closed this Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.