-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plug-able annotation system #61
Conversation
👍 |
Ok the Travis build failed cause |
would greatly appreciate this! |
Looks promising 👍 Thoughts on this @btford? |
Please support minification of $routeProvider resolve functions |
+1 |
2 similar comments
+1 |
+1 |
I need to fix up some things, but I'd be happy to add this. |
Thats nice to hear :) I would provide some ui-router annotations cause these seem the most requested ones and we need them too. Would you be happy with the I will add documentation for plugin creation. |
I created some |
+1 |
+1 |
1 similar comment
+1 |
+1 |
…ngmin#89, btford/ngmin#87, btford/ngmin#85, btford/ngmin#78, btford/ngmin#77, btford/ngmin#73, btford/ngmin#70, btford/ngmin#64, btford/ngmin#63, btford/ngmin#61, btford/ngmin#59, btford/ngmin#57, btford/ngmin#56, btford/ngmin#54, btford/ngmin#50, btford/ngmin#46, btford/ngmin#43, btford/ngmin#42, btford/ngmin#37, btford/ngmin#35, btford/ngmin#22
👍 |
ngmin is now deprecated: #93 Maybe make sure ng-annotate supports something like this and if not, get a pr there for this? |
I add the possibility to extend ngmin with annotation packages which are prefixed with
astral-angular-annotate-
. One extension can be found here https://github.com/werk85/astral-angular-annotate-ng-route. This addsresolve
support to the ngRoute annotations.The target of this pull request is to make ngmin more open and allow external angular libraries to provide their own annotations. This would resolve many issues here in the issue tracker. Also would it be possible for the angular team to split up their annotations in separate packages.
This is not finished yet, but it would be nice to get some feedback.
Thanks to @sindresorhus who inspired me to this implementation.