Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in asset search #3

Closed
btk opened this issue Sep 28, 2017 · 10 comments
Closed

Built-in asset search #3

btk opened this issue Sep 28, 2017 · 10 comments

Comments

@btk
Copy link
Owner

btk commented Sep 28, 2017

Allow user to do a simple array search in the assets object created. This can be implemented in the asset module as a method.

@faraazahmad
Copy link
Contributor

I'm assuming the search function will take a parameter and return the object of the asset if search succeeds. Am I right?

@btk
Copy link
Owner Author

btk commented Sep 28, 2017

@faraazahmad you are right, also we can use the search function as a prototype for the included asset object maybe? Like with kind of a syntax of;

Assets.search("cars")

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/prototype

Decision is yours.

@faraazahmad
Copy link
Contributor

https://jsfiddle.net/dzo3evwb/

Would this be fine?

@btk
Copy link
Owner Author

btk commented Sep 28, 2017

@faraazahmad yeah that looks great

@btk
Copy link
Owner Author

btk commented Sep 28, 2017

@faraazahmad just so you know, waiting for your pull request.

@faraazahmad
Copy link
Contributor

Can you, like, merge it in october 😅 ?

@btk
Copy link
Owner Author

btk commented Sep 28, 2017

@faraazahmad Alright, can you give me a link that specifies anything about the merges should be done in October, I don't think there is a rule like that?

@faraazahmad
Copy link
Contributor

https://hacktoberfest.digitalocean.com/#details
it says about making pull requests in oct, i guess I erred

@faraazahmad
Copy link
Contributor

I'll contribute nevertheless 😎

@btk
Copy link
Owner Author

btk commented Oct 1, 2017

#10

@btk btk closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants