Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout in every view folder #5

Closed
vadiraja opened this issue Nov 25, 2013 · 2 comments
Closed

Layout in every view folder #5

vadiraja opened this issue Nov 25, 2013 · 2 comments

Comments

@vadiraja
Copy link

Is there any specific reason as to why you have layout template in every view folder?

@matthewarkin
Copy link
Contributor

Since you pointed this out I went and checked it out and set all the views to point to a layout.jade in the parent, which broke the checkout.

The checkout layouts don't include the categories, besides that the other layouts appear to be the same, though I'm a bit lazy to do a diff on them.

Using some jade inheritance, you can have the base layout. Each folder than optionally includes the category nav in its layout, which inherits from the base. I ended up doing this and have a pull request in.

@btply
Copy link
Owner

btply commented Nov 25, 2013

Thanks for changing that matt, I was in the process of doing this for the admin side as well as getting rid of the data.js file which is fairly pointless

@btply btply closed this as completed Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants