Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw informative errors for methods that don't work in browser #30

Closed
bttmly opened this issue Dec 16, 2016 · 1 comment
Closed

Throw informative errors for methods that don't work in browser #30

bttmly opened this issue Dec 16, 2016 · 1 comment

Comments

@bttmly
Copy link
Owner

bttmly commented Dec 16, 2016

Some methods (stats.playerSplits and stats.scoreboard) the NBA checks referrer headers and denies access unless the value is stats.nba.com. We can't set headers when using JSONP so this library should throw an informative error when trying to use these methods in a browser context.
@bttmly bttmly mentioned this issue Dec 16, 2016
Closed
@bttmly
Copy link
Owner Author

bttmly commented May 2, 2019

the NBA is locking down most endpoints by preventing CORS so for now this package only supports non-browser environments (node.js)

@bttmly bttmly closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bttmly