Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test t/12placeholders.t fails in 3.8.0 on some architectures #46

Closed
jplesnik opened this issue Apr 26, 2019 · 1 comment
Closed

Test t/12placeholders.t fails in 3.8.0 on some architectures #46

jplesnik opened this issue Apr 26, 2019 · 1 comment

Comments

@jplesnik
Copy link

jplesnik commented Apr 26, 2019

I tried to update perl-DBD-pg in Fedora, but the test 12placeholders.t fails on architectures ppc64le, s390x, aarch64, armv7hl. The failure is related to the commit 'Handle backslash-escaped quotes in E'' strings' (dc83d01)

The problem is that char can equal to unsigned char on some architectures. In this case, the assignment char non_standard_strings = -1; can be undefined and the following condition is not evaluated properly.
I fixed it by replacing 'char' with 'signed char'.

@ilmari
Copy link
Collaborator

ilmari commented Apr 26, 2019

Thanks for the report, fixed in commit 5006a4a.

@ilmari ilmari closed this as completed Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants