Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Access denied" errors are not handled properly #66

Open
fingolfin opened this issue Mar 25, 2013 · 1 comment
Open

"Access denied" errors are not handled properly #66

fingolfin opened this issue Mar 25, 2013 · 1 comment
Labels

Comments

@fingolfin
Copy link
Collaborator

I just had an odd experienced where I did a "git push" via gitifyhg to a hg repository, and no errors were reported. Yet when I tried to pull the changes in a hg clone of the same repository, no changes arrived. I repeated this two more times (each time adding another commit), still nothing.

I finally went into .git/hg/*/clone and issued a "hg push" there, only to get this message"

pushing to ssh://hg@some.server/repos
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 3 changesets with 7 changes to 7 files
remote: error: pretxnchangegroup.access hook failed: mercurialserver.access: access denied for changeset XYZ
remote: transaction abort!
remote: rollback completed
remote: abort: mercurialserver.access: access denied for changeset XYZ

So it seems we should handle access denied errors, and inform the user accordingly. Instead of making it look as if everything succeeded.

@alexsydell
Copy link
Contributor

I think taking care of this TODO would accomplish that: https://github.com/buchuki/gitifyhg/blob/master/gitifyhg/gitexporter.py#L102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants