Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-tabs is-disabled css rule influences the tab content #1351

Closed
s-nesbigall opened this issue Apr 26, 2019 · 0 comments
Closed

b-tabs is-disabled css rule influences the tab content #1351

s-nesbigall opened this issue Apr 26, 2019 · 0 comments
Assignees
Labels

Comments

@s-nesbigall
Copy link
Contributor

s-nesbigall commented Apr 26, 2019

Overview of the problem

Buefy version: 0.7.4
Vuejs version: 2.6.10
OS/Browser: Google Chrome

Description

The tabs is-diabled css rule

.b-tabs .is-disabled {
    pointer-events: none;
    cursor: not-allowed;
    opacity: .5;
}

is not only applied to the tab nav item, but also to the content.
It therefore overwrites other is-disabled behaviour if disabled components are inside the tab (e.g. a disabled datepicker).

Steps to reproduce

<section>
  <b-tabs v-model="activeTab">
    <b-tab-item label="MyTab">
      <b-datepicker icon="calendar" disabled/>
    </b-tab-item>
  </b-tabs>
  <b-datepicker icon="calendar" disabled/>
</section>

Expected behavior

The datepicker inside the tab should also have e.g. a not-allowed cursor.
I would expect the CSS rule

.b-tabs .is-disabled {
    pointer-events: none;
    cursor: not-allowed;
    opacity: .5;
}

to only affect the tabs nav, not the complete tab-item content.
So the rule should maybe be:

.b-tabs .tabs .is-disabled {
    pointer-events: none;
    cursor: not-allowed;
    opacity: .5;
}

Actual behavior

The datepicker inside the tab has no not-allowed cursor, beacause it gets overwriten by

.b-tabs .is-disabled {
    pointer-events: none;
    cursor: not-allowed;
    opacity: .5;
}
@jtommy jtommy self-assigned this Apr 26, 2019
@jtommy jtommy added the bug label Apr 26, 2019
@jtommy jtommy closed this as completed in 6cf0389 Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants