Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouped/addons size with inside labels #1761

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

service-paradis
Copy link
Collaborator

Adapt grouped or addons elements height if we use label-position="inside"

Proposed Changes

  • Keep every grouped elements the same height

Results

image

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #1761 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1761   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files          61       61           
  Lines        2200     2200           
  Branches      696      696           
=======================================
  Hits         1308     1308           
  Misses        820      820           
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33d675...e4ba827. Read the comment docs.

@service-paradis
Copy link
Collaborator Author

service-paradis commented Sep 12, 2019

The #1758 case is not resolved using this PR since there is a b-field inside another b-field without any .control. This would need another fix.

ex:

<b-field grouped>
    <b-field label="Search" label-position="inside">
            <b-input />
    </b-field>
    <b-button>Submit</b-button>
</b-field>

This fix will work if used like this:

<b-field label="Search..." label-position="inside" grouped>
    <b-input placeholder="Search..." type="search"></b-input>
    <p class="control">
        <b-button class="button is-primary">Search</b-button>
    </p>
</b-field>

@jtommy jtommy merged commit a19f09b into buefy:dev Sep 17, 2019
LeoMouyna pushed a commit to LeoMouyna/buefy that referenced this pull request Jan 6, 2020
* Fix grouped/addons size with inside labels

* Use b-button instead of button
LeoMouyna pushed a commit to LeoMouyna/buefy that referenced this pull request Jan 6, 2020
* Fix grouped/addons size with inside labels

* Use b-button instead of button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants