Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trouble with coma key (188) on taginput #531

Closed
ghost opened this issue Jan 15, 2018 · 2 comments
Closed

Trouble with coma key (188) on taginput #531

ghost opened this issue Jan 15, 2018 · 2 comments
Assignees
@jtommy
Labels
improvement

Comments

@ghost
Copy link

ghost commented Jan 15, 2018

Hi guys!
There is some trouble with the taginput. It's ok for eng language, but when I try to write tags on russian/ukrainian languages and press key "," its add tag instead of add russian/ukrainian letter "Б" to the input field.
I highly recommend to delete event.keyCode === 188 from the source code in TagInput.vue on 202 string.
@jtommy
Copy link
Member

jtommy commented Jan 19, 2018

@MMysiv We might add a new prop to set an array of key codes to use as tag separator. In this way you can remove o add default key codes.

@ghost
Copy link
Author

ghost commented Jan 24, 2018

It would be great! I'll look forward to it.

@jtommy jtommy self-assigned this Jan 24, 2018
@jtommy jtommy closed this as completed in 9cc6a59 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtommy jtommy

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtommy