Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split production & mock plugins #71

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Split production & mock plugins #71

merged 6 commits into from
Jan 17, 2023

Conversation

rebello95
Copy link
Collaborator

@rebello95 rebello95 commented Jan 15, 2023

This PR splits the protoc-gen-connect-swift plugin into 2, both of which use the same set of options:

  • protoc-gen-connect-swift: Generates interfaces and production implementations
  • protoc-gen-connect-swift-mocks: Generates mock implementations

Both of these plugins depend on a shared ConnectPluginUtilities module, and the repo has been reorganized to be more concise at the top-level:

├── Connect-Swift-Mocks.podspec
├── Connect-Swift.podspec
├── Examples
│   ├── ElizaCocoaPodsApp
│   ├── ElizaSharedSources
│   ├── ElizaSwiftPackageApp
│   ├── README.md
│   ├── buf.gen.yaml
│   ├── buf.work.yaml
│   └── proto
├── LICENSE
├── Libraries
│   ├── Connect
│   └── ConnectMocks
├── Makefile
├── Package.resolved
├── Package.swift
├── Plugins
│   ├── ConnectMocksPlugin
│   ├── ConnectPluginUtilities
│   └── ConnectSwiftPlugin
├── README.md
└── Tests
    ├── ConnectLibraryTests
    └── ConnectPluginUtilitiesTests

@rebello95 rebello95 marked this pull request as ready for review January 16, 2023 20:39
@rebello95 rebello95 changed the title [Draft] Split production & mock plugins Split production & mock plugins Jan 16, 2023
Base automatically changed from default-async to main January 17, 2023 17:25
@rebello95 rebello95 merged commit 9566575 into main Jan 17, 2023
@rebello95 rebello95 deleted the split-plugins branch January 17, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants