-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-Shaking for fields
#769
Comments
Hey Cyril, I think you're right that the call to
I believe that adding a But before we make this change, we need to verify that it actually works as expected (previous changes were tested with https://github.com/connectrpc/examples-es/tree/main/bundle-size). This will take us a bit to look into, but it looks worthwhile to me. Thanks for filing the issue! |
Hi @liril-net. We tested adding this annotation to the Are you noticing anything different with Rollup? Or do you see anything missing from how we are bundling in our tests? |
Let's close this. See connectrpc/examples-es#1499 (comment) for details. |
Hi there, i am working with this fantastic package in my project, but i found it not works with
tree-shaking
and as project grows, it becomes so large for the output files.I find that maybe the
static readonly fields: FieldList
make the rollup tree-shaking not works as it initialized.Can we make it as a function such as
getFields()
to make it lazy init to let the tree-shaking works?The text was updated successfully, but these errors were encountered: