-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treeshaking #1499
Treeshaking #1499
Conversation
@timostamm here's an example of trying the ParcelParcel doesn't seem to be tree-shaking any code from Also, Parcel's numbers aren't affected at all because the output is minified by default and the comments are stripped away. You can turn it off with RollupThe Rollup claims that it removes invalid annotations and emits a warning, but I don't see any warning in the build (with ViteLike Rollup, the WebpackLike Rollup and Vite, the |
Hi @smaye81 , i think it not works because now the |
Ah right. Thanks for the clarification. I don't think we will be making that lazy-initialization refactor since that would be breaking change to generated code. We are actually working on a v2 of Protobuf-ES and plan to release an alpha version shortly, so bundle sizes, etc. will be a bit in flux. We can revisit once we get a better benchmark with the v2 release. In the meantime, let's keep bufbuild/protobuf-es#769 open just for tracking so that we can verify when the release is ready. |
cool, where can i see the v2 working progress? |
Work is being done on the |
The |
No description provided.