Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 class constructors #65

Open
garthreckers opened this issue Nov 30, 2016 · 1 comment
Open

PHP7 class constructors #65

garthreckers opened this issue Nov 30, 2016 · 1 comment

Comments

@garthreckers
Copy link

All of the classes in dd-class.php use the old style constructor (name of class as function). Can these get updated to use __construct instead for future releases? Would hate to have to update that file manually each time there is a new version.

@aronmarriott-smith
Copy link
Contributor

Hi @garthreckers, I agree with you on updating the class constructors to use __construct rather than the old PHP4 way. I have started work on a feature branch with Travis IC unit testing so we can see the deprecated errors in PHP7: https://travis-ci.org/aronmarriott-smith/diggdigg/jobs/180271282
As you probably already know there are a lot of deprecated warnings generated!

It may be a good idea to create a pull request with the changes you made to resolve the issue, then hopefully @katzien can merge it in and update the plugin on wordpress.org?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants