Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undeclared ActiveSupport dependency on .try #26

Closed
adamrdavid opened this issue May 16, 2018 · 0 comments · Fixed by #30
Closed

Fix undeclared ActiveSupport dependency on .try #26

adamrdavid opened this issue May 16, 2018 · 0 comments · Fixed by #30

Comments

@adamrdavid
Copy link
Contributor

adamrdavid commented May 16, 2018 •
edited
Loading

This uses the .try method that is defined by ActiveSupport, but we do not depend on ActiveSupport
https://github.com/bugcrowd/vrt-ruby/pull/24/files#diff-2c90cdf2771394e4027dd3237e210d0fR30

We do not want to depend on ActiveSupport so let's find a way to remove that.

More importantly that code path is not tested so let's make a spec for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

There is no try bugcrowd/vrt-ruby
1 participant
@adamrdavid