Alter bugsnag extension to allow multiple shared object paths #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
v5-shared-object-path
branch
from
c75dd5c
to
e7aac82
Compare
fractalwrench
force-pushed
the
v5-shared-object-path
branch
from
e7aac82
to
d4d08bf
Compare
imjoehaines
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows users to specify multiple shared object paths via the bugsnag plugin extension. Previously it was only possible to specify one shared object path, which meant only one directory could be searched for SO files to upload. The previous API also had to be supplied as a relative path as a string rather than a
Filewhich led to user confusion.Changeset
String bugsnag.sharedObjectPathin favour ofList<File> bugsnag.sharedObjectPathsBugsnagUploadNdkTaskto handle multiple shared object pathsBugsnagUploadNdkTaskTests
Verified that each shared object path specified in a local example app is searched.