Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing outputfile configuration #240

Merged
merged 13 commits into from
Jul 28, 2020

Conversation

ZacSweers
Copy link
Contributor

@ZacSweers
Copy link
Contributor Author

This seems to be an issue in AGP, filed https://issuetracker.google.com/issues/161920328

@fractalwrench
Copy link
Contributor

Thanks for digging down into this Zac - it looks like we'll need to wait for the resolution of the issue in AGP.

@ZacSweers
Copy link
Contributor Author

it looks like it's never getting a callback in onVariants 🤔

@ZacSweers
Copy link
Contributor Author

So the wiring works now, but it looks like there's unrelated stuff failing (version code, mapping files, etc), possibly on the branch itself?

@fractalwrench
Copy link
Contributor

I made a couple of changes to get this passing:

  1. The test fixture that runs against AGP 3.4.0 was failing on some of the APK splits scenarios as the task name used the name of the ApkVariant, rather than the ApkVariantOutput, which isn't unique.
  2. Some of the APK split tests were failing on AGP 4.1.0, so I've moved them to only run on AGP 3.4.0.

I'm assuming that there isn't an AGP 4.1.0 API for accessing APK splits because using App Bundles is preferred. If this isn't the case and it's possible to support APK splits then I imagine further changes will be needed to support that.

Thanks again for the contribution! I'll merge this down to the v5-fixture-dep-bump branch and wait to confirm that there isn't an API for supporting APK splits in AGP 4.1.0 (and also alert our product folks about this).

@fractalwrench fractalwrench merged commit 6ff864c into bugsnag:v5-fixture-dep-bump Jul 28, 2020
@ZacSweers ZacSweers deleted the z/v5fixturebits branch July 28, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants