Add uploadNdkUnityLibraryMappings flag to bugsnag extension #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-4964/extension-flag
branch
from
8ae378e
to
2d5bf26
Compare
imjoehaines
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the
uploadNdkUnityLibraryMappingsflag to the bugsnag plugin extension.By default this value is null and the plugin will use the presence of
unity.3din theandroid.aaptOptions.noCompresscollection as evidence that the project is Unity. If a user supplies a property value this will be preferred instead.Testing
Added unit tests to verify that the heuristic works correctly. Additional test coverage for overwriting the other properties on the bugsnag plugin extension was also added.