Prevent windows crash when generating Unity mapping files #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5350/unity-windows
branch
from
adcf2d3
to
7d1d4b0
Compare
tomlongridge
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents a crash on Windows when generating Unity mapping files. The
rootProjectDirwas unnecessarily defined as a task input, which is hashed by Gradle for the purposes of knowing whether to cache the output or not. On Windows a file lock is taken out on this directory which prevents the hash, throwing an exception. Marking the property as internal instead means no exception is thrown.Testing
Ran on a Windows machine and verified that the task completed without throwing an exception when using a local artefact.
It's worth noting that objdump appears to fail to generate SO files for libunity/libil2cpp, so this will require further investigation - but this fixes the immediate issue of crashing in the plugin.