Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-11640] Fix React Native CLI for RN 0.73 #2091

Merged
merged 10 commits into from Feb 27, 2024
Merged

[PLAT-11640] Fix React Native CLI for RN 0.73 #2091

merged 10 commits into from Feb 27, 2024

Conversation

joshedney
Copy link
Contributor

Goal

Ensure that the react native cli works with RN 0.73

Changeset

Added additional checks around finding MainApplication as in RN 0.73 it is no longer MainApplication.java but MainApplication. I've also added MainApplication.kt as this file was mentioned in the bug ticket but I'm unable to see that file when generating a new RN 0.73 project.

Testing

Covered by CI

@joshedney joshedney self-assigned this Feb 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.70 kB 13.40 kB
After 43.70 kB 13.40 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against fb30861

gingerbenw
gingerbenw approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@gingerbenw gingerbenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just suggested a simplification for the Insert.ts script.

packages/react-native-cli/src/lib/Insert.ts Outdated Show resolved Hide resolved
@joshedney @gingerbenw
Update packages/react-native-cli/src/lib/Insert.ts
fb30861 
Co-authored-by: Ben Wilson <ben.wilson@smartbear.com>
@joshedney joshedney merged commit 030ac98 into next Feb 27, 2024
71 checks passed
@joshedney joshedney deleted the je/plat-11640 branch February 27, 2024 16:48
This was referenced Mar 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerbenw gingerbenw gingerbenw approved these changes

@lemnik lemnik Awaiting requested review from lemnik

@yousif-bugsnag yousif-bugsnag Awaiting requested review from yousif-bugsnag

Assignees

@joshedney joshedney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshedney @gingerbenw