Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11640] Fix React Native CLI for RN 0.73 #2091

Merged
merged 10 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/react-native-cli/src/lib/Gradle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@ export async function getSuggestedBugsnagGradleVersion (projectRoot: string, log
const versionMatchResult = fileContents.match(/classpath\(["']com.android.tools.build:gradle["']\)/)
if (versionMatchResult) {
return '7.+'
}
logger.warn(`Cannot determine an appropriate version of the Bugsnag Android Gradle plugin for use in this project.
} else {
logger.warn(`Cannot determine an appropriate version of the Bugsnag Android Gradle plugin for use in this project.

Please see ${DOCS_LINK} for information on Gradle and the Android Gradle Plugin (AGP) compatibility`)
return ''
return ''
}
}
}

Expand Down
23 changes: 18 additions & 5 deletions packages/react-native-cli/src/lib/Insert.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,26 @@ export async function insertAndroid (projectRoot: string, logger: Logger): Promi
let mainApplicationPath
try {
const javaDir = path.join(projectRoot, 'android', 'app', 'src', 'main', 'java')
const relativeMainApplicationPath = (await asyncGlob('**/*/MainApplication.java', {
const relativeMainApplicationPathJava = (await asyncGlob('**/*/MainApplication.java', {
cwd: javaDir
}))[0]
if (!relativeMainApplicationPath) return logger.warn(FAIL_MSG('MainApplication.java'))

const relativeMainApplicationPathKotlin = (await asyncGlob('**/*/MainApplication.kt', {
cwd: javaDir
}))[0]

const relativeMainApplicationPathOther = (await asyncGlob('**/*/MainApplication', {
cwd: javaDir
}))[0]

const relativeMainApplicationPath = relativeMainApplicationPathJava || relativeMainApplicationPathKotlin || relativeMainApplicationPathOther

if (!relativeMainApplicationPath) {
return logger.warn(FAIL_MSG('MainApplication.java, MainApplication.kt or MainApplication'))
}
mainApplicationPath = path.join(javaDir, relativeMainApplicationPath)
} catch (e) {
logger.warn(FAIL_MSG('MainApplication.java'))
logger.warn(FAIL_MSG('MainApplication.java, MainApplication.kt or MainApplication'))
return
}

Expand All @@ -127,13 +140,13 @@ export async function insertAndroid (projectRoot: string, logger: Logger): Promi
const mainApplicationWithImport = mainApplication.replace('import', `${BUGSNAG_JAVA_IMPORT}\nimport`)
const onCreateRes = JAVA_APP_ON_CREATE_REGEX.exec(mainApplicationWithImport)
if (!onCreateRes) {
logger.warn(FAIL_MSG('MainApplication.java'))
logger.warn(FAIL_MSG('MainApplication.java, MainApplication.kt or MainApplication'))
return
}

await fs.writeFile(mainApplicationPath, mainApplicationWithImport.replace(onCreateRes[1], `${onCreateRes[1]}${BUGSNAG_JAVA_INIT}${onCreateRes[2]}`), 'utf8')
logger.success('Done')
} catch (e) {
logger.error(FAIL_MSG('MainApplication.java'))
logger.error(FAIL_MSG('MainApplication.java, MainApplication.kt or MainApplication'))
}
}
8 changes: 4 additions & 4 deletions packages/react-native-cli/src/lib/__test__/Insert.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ test('insertAndroid(): failure to locate file', async () => {
)
expect(writeFileMock).not.toHaveBeenCalled()

expect(logger.error).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java" automatically.'))
expect(logger.error).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java, MainApplication.kt or MainApplication" automatically.'))
})

test('insertAndroid(): failure to locate package directory', async () => {
Expand All @@ -279,7 +279,7 @@ test('insertAndroid(): failure to locate package directory', async () => {
expect(readFileMock).not.toHaveBeenCalled()
expect(writeFileMock).not.toHaveBeenCalled()

expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java" automatically.'))
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java, MainApplication.kt or MainApplication" automatically.'))
})

test('insertAndroid(): project directory error', async () => {
Expand All @@ -293,7 +293,7 @@ test('insertAndroid(): project directory error', async () => {
expect(readFileMock).not.toHaveBeenCalled()
expect(writeFileMock).not.toHaveBeenCalled()

expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java" automatically.'))
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java, MainApplication.kt or MainApplication" automatically.'))
})

test('insertAndroid(): no identifiable onCreate method', async () => {
Expand All @@ -311,5 +311,5 @@ test('insertAndroid(): no identifiable onCreate method', async () => {
)
expect(writeFileMock).not.toHaveBeenCalled()

expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java" automatically.'))
expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Failed to update "MainApplication.java, MainApplication.kt or MainApplication" automatically.'))
})
Loading