This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Severity #21
Merged
Severity #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2014
| @@ -21,6 +23,13 @@ module.exports = class Notification | |||
| event.appVersion = Configuration.appVersion if Configuration.appVersion | |||
| event.releaseStage = Configuration.releaseStage if Configuration.releaseStage | |||
|
|
|||
| event.payloadVersion = Configuration.payloadVersion if Configuration.payloadVersion | |||
|
|
|||
| if options.severity? and SUPPORTED_SEVERITIES.include?(options.severity) | |||
There was a problem hiding this comment.
Does .include? work — I though that was a ruby thing.
There was a problem hiding this comment.
No, it doesn't, and I had the right thing there at first too. Was switching between this and Ruby, must have gotten twisted up :)
| @@ -125,6 +125,7 @@ module.exports = Bugsnag = (function() { | |||
| } | |||
| dom = domain.create(); | |||
| dom._bugsnagOptions = options; | |||
| options["severity"] = "error"; | |||
There was a problem hiding this comment.
I think we also need to do this in requestHandler
|
Do we want severity=error on |
|
We definitely do want it in |
|
Other than that, 🍬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add severities & payloadVersion.
Related Pull Requests:
bugsnag/bugsnag-website#189
bugsnag/bugsnag-notifier-api#3
bugsnag/bugsnag-event-worker#59
bugsnag/bugsnag-ruby#96
bugsnag/bugsnag-php#39
bugsnag/bugsnag-cocoa#14
bugsnag/bugsnag-java#13
bugsnag/bugsnag-js#41
bugsnag/bugsnag-android#15
bugsnag/bugsnag-python#23