Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to go back to home page. #150

Closed
shinebayar-g opened this issue Dec 19, 2018 · 9 comments
Closed

There is no way to go back to home page. #150

shinebayar-g opened this issue Dec 19, 2018 · 9 comments

Comments

@shinebayar-g
Copy link
Collaborator

shinebayar-g commented Dec 19, 2018

Hi, as title says there is no way to go back to home page. Reason why we need is:
If I execute one script it stays as check marked and doesn't refresh. So there is a way to refresh to get rid out of this check mark. And there is no button to click to refresh or go back to home page. So I'd like to add href link on Script server word. PRs are welcome?

image

@bugy
Copy link
Owner

bugy commented Dec 19, 2018

Hi @shinebayar-g, just for better understanding: why do you want to get rid of this mark? You can execute the same script again without any problems. It is just showing that the script is finished until "any" further action (see below)
In my opinion nobody would need to go to a home screen, there is nothing useful there :) I even didnt put much efforts on making it useful

Two ways to get rid of it:

  1. Refresh the page
  2. Navigate to another script (which you don't have according to the screenshot)

But PRs are always welcome :) You can make "Script server" text in the left upper corder a link (but please keep styles: black font and no underlines)

@shinebayar-g
Copy link
Collaborator Author

shinebayar-g commented Dec 19, 2018

Ye, I thought If I add more scripts check mark would disappear if I select between scripts. Noted.

EDIT: I really really don't like to refresh the page.

@bugy
Copy link
Owner

bugy commented Dec 19, 2018

:) But why don't you like this check mark?

@shinebayar-g
Copy link
Collaborator Author

shinebayar-g commented Dec 19, 2018

I don't know it just feels off, I'd provide more feedback after I get used to the project in few days.

@bugy
Copy link
Owner

bugy commented Dec 19, 2018

I see. But navigation to a home screen itself is not needed for you, right?

@shinebayar-g
Copy link
Collaborator Author

It is indeed needed. Navigate to home page , feels like you type something wrong and just click CTRL + C instead of deleting mistyped characters. You don't like to make it link tbh?

@bugy
Copy link
Owner

bugy commented Dec 19, 2018

I think the link to a homepage is ok for almost any website :)

The problem for me, is that I would like to fix the root cause why anybody would want to go to the homepage. I'm completely fine for this link to exist, but I would like that people wouldn't need to use it

Regarding your usecase, I think that some kind of "Reset" button would be helpful. It could clean the check mark and all parameter values for the currently open script. Do I understand correctly?

@shinebayar-g
Copy link
Collaborator Author

Umm, that could be useful too! Reload or refresh button that doesn't perform full page reload, but reloads certain element would be cool.

@bugy bugy added the feature label Jan 17, 2019
@bugy
Copy link
Owner

bugy commented Dec 29, 2019

Now Script server title is clickable and leads to a "home page" (black page basically)
In future, I'm planning to support #145 with a possibility to start a new script from scratch (i.e. reset current parameters)

@bugy bugy added the resolved label Dec 29, 2019
@bugy bugy added this to the 1.15.0 milestone Dec 29, 2019
@bugy bugy closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants