Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to filter ApiSession events when subscribing #4

Open
victorholo opened this issue Feb 21, 2022 · 0 comments
Open

Ability to filter ApiSession events when subscribing #4

victorholo opened this issue Feb 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@victorholo
Copy link
Contributor

Current ApiSession execute method is using a getReceipt boolean flag which we would like to remove.

We think this flag is extra considering the returnType which can be: TypeOfExecutionReturn.Record, TypeOfExecutionReturn.Receipt or TypeOfExecutionReturn.Result.

If we do get a receipt, considering the returnType, we want to emit it if there are any listeners subscribed for TRANSACTION_ON_RECEIPT_EVENT_NAME event.

Considering the fact that there are multiple types of transactions which are done, we want to give user the ability to filter out some of this transactions if needed.

It would be great to have use a wrapper for the EventEmitter so we can filter some of these transactions out, based on transaction type and maybe also by the status on the receipt.

@victorholo victorholo added the enhancement New feature or request label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant