Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passwordConfirmation handling to *Arr general settings models #215

Open
Callum027 opened this issue Apr 29, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working plugins Vendored plugin or plugin API-related issue or pull request
Milestone

Comments

@Callum027
Copy link
Member

Callum027 commented Apr 29, 2024

Newer versions of the *Arr applications now require a passwordConfirmation attribute to be present in the update API requests for the general settings.

Buildarr's plugins do not support this attribute, which is the cause of the password confirmation errors we're seeing in Radarr and Prowlarr.

buildarr  | send: b'PUT /api/v1/config/host/1 HTTP/1.1\r\nHost: prowlarr:9696\r\nAccept-Encoding: identity\r\nContent-Length: 872\r\nAccept: application/json\r\nContent-Type: application/json\r\nUser-Agent: prowlarr-py/v0.4.1\r\nX-Api-Key: <snip>\r\n\r\n'
buildarr  | send: b'{"id": 1, "bindAddress": "*", "port": 9696, "sslPort": 6969, "enableSsl": false, "launchBrowser": true, "authenticationMethod": "external", "authenticationRequired": "disabledForLocalAddresses", "analyticsEnabled": false, "username": "", "password": "", "logLevel": "debug", "consoleLogLevel": "", "branch": "master", "apiKey": "<snip>", "sslCertPath": "", "sslCertPassword": "", "urlBase": "", "instanceName": "Prowlarr", "applicationUrl": "", "updateAutomatically": false, "updateMechanism": "docker", "updateScriptPath": "", "proxyEnabled": false, "proxyType": "http", "proxyHostname": "", "proxyPort": 8080, "proxyUsername": "", "proxyPassword": "", "proxyBypassFilter": "", "proxyBypassLocalAddresses": true, "certificateValidation": "enabled", "backupFolder": "Backups", "backupInterval": 7, "backupRetention": 28, "historyCleanupDays": 30}'

Update the DevOpsArr Python API libraries to gain support for this parameter (requires Pydantic V2 support on the plugins), and if necessary, add processing on the Buildarr side to make it at least work enough that no errors occur.

@Callum027 Callum027 added bug Something isn't working plugins Vendored plugin or plugin API-related issue or pull request labels Apr 29, 2024
@Callum027 Callum027 added this to the v0.8.0 milestone Apr 29, 2024
@Callum027 Callum027 self-assigned this Apr 29, 2024
@Callum027 Callum027 changed the title Add the password_confirmation field to *Arr general settings models Add passwordConfirmation handling to *Arr general settings models Apr 29, 2024
@Callum027
Copy link
Member Author

Quickly checking how the username and password fields work in the General Settings, it appears they are transmitted in plaintext to the server.

That means all we should have to do is make sure passwordConfirmation is set to the same value as password, and username/password management should then work correctly in Buildarr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins Vendored plugin or plugin API-related issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant